• Lv Zheng's avatar
    ACPICA: Prevent possible build issues for use of ACPI_PRINTF_LIKE macro · 4506bf23
    Lv Zheng authored
    The following build error:
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       CC      arch/x86/kernel/setup.o
     In file included from include/acpi/acpi.h:64:0,
                      from include/linux/iscsi_ibft.h:24,
                      from arch/x86/kernel/setup.c:43:
     include/acpi/acpixf.h:543:1: error: expected ',' or ';' before '{' token
     include/acpi/acpixf.h:540:1: warning: 'acpi_error' declared 'static' but never defined [-Wunused-function]
     make[2]: *** [arch/x86/kernel/setup.o] Error 1
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    can be triggerred by the following stub function (if implemented):
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     static inline void ACPI_INTERNAL_VAR_XFACE
     acpi_error(const char *module_name,
     	   u32 line_number, const char *format, ...) ACPI_PRINTF_LIKE(3)
     {
     }
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    This patch changes the position of ACPI_PRINTF_LIKE(x) to follow the
    style of __printf(x, x+1) used in Linux to prevent such issues from
    happening.  Lv Zheng.
    Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
    Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    4506bf23
acpixf.h 16.7 KB