• Ben Hutchings's avatar
    sfc: Fix memory leak when discarding scattered packets · 734d4e15
    Ben Hutchings authored
    Commit 2768935a ('sfc: reuse pages to avoid DMA mapping/unmapping
    costs') did not fully take account of DMA scattering which was
    introduced immediately before.  If a received packet is invalid and
    must be discarded, we only drop a reference to the first buffer's
    page, but we need to drop a reference for each buffer the packet
    used.
    
    I think this bug was missed partly because efx_recycle_rx_buffers()
    was not renamed and so no longer does what its name says.  It does not
    change the state of buffers, but only prepares the underlying pages
    for recycling.  Rename it accordingly.
    Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    734d4e15
rx.c 22.9 KB