• Alex Elder's avatar
    lib/parser.c: avoid overflow in match_number() · 77dd3b0b
    Alex Elder authored
    The result of converting an integer value to another signed integer type
    that's unable to represent the original value is implementation defined.
    (See notes in section 6.3.1.3 of the C standard.)
    
    In match_number(), the result of simple_strtol() (which returns type long)
    is assigned to a value of type int.
    
    Instead, handle the result of simple_strtol() in a well-defined way, and
    return -ERANGE if the result won't fit in the int variable used to hold
    the parsed result.
    
    No current callers pay attention to the particular error value returned,
    so this additional return code shouldn't do any harm.
    
    [akpm@linux-foundation.org: coding-style tweaks]
    Signed-off-by: default avatarAlex Elder <elder@inktank.com>
    Cc: Randy Dunlap <rdunlap@xenotime.net>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    77dd3b0b
parser.c 6.2 KB