• Lee Jones's avatar
    mfd: ab8500-core: Resolve code style issues · 7ccf40b1
    Lee Jones authored
    Soothes the following checkpatch warnings:
    
        WARNING: line over 80 characters
        #151: FILE: drivers/mfd/ab8500-core.c:151:
        +	0, 1, 2, 3, 4, -1, -1, -1, -1, 11, 18, 19, 20, 21, 12, 13, 24, 5, 22, 23,
    
        ERROR: spaces required around that '=' (ctx:VxW)
        #325: FILE: drivers/mfd/ab8500-core.c:325:
        +	ret= mask_and_set_register_interruptible(ab8500, bank, reg,
         	   ^
    
        WARNING: line over 80 characters
        #418: FILE: drivers/mfd/ab8500-core.c:418:
        +		else if (offset >= AB9540_INT_GPIO50R && offset <= AB9540_INT_GPIO54R)
    
        WARNING: line over 80 characters
        #420: FILE: drivers/mfd/ab8500-core.c:420:
        +		else if (offset == AB8540_INT_GPIO43R || offset == AB8540_INT_GPIO44R)
    
        ERROR: spaces required around that '==' (ctx:VxV)
        #454: FILE: drivers/mfd/ab8500-core.c:454:
        +	if ((i==3) && (*offset >= 24))
         	      ^
    
        ERROR: code indent should use tabs where possible
        #576: FILE: drivers/mfd/ab8500-core.c:576:
        +        .map    = ab8500_irq_map,$
    
        WARNING: please, no spaces at the start of a line
        #576: FILE: drivers/mfd/ab8500-core.c:576:
        +        .map    = ab8500_irq_map,$
    
        ERROR: code indent should use tabs where possible
        #577: FILE: drivers/mfd/ab8500-core.c:577:
        +        .xlate  = irq_domain_xlate_twocell,$
    
        WARNING: please, no spaces at the start of a line
        #577: FILE: drivers/mfd/ab8500-core.c:577:
        +        .xlate  = irq_domain_xlate_twocell,$
    
        WARNING: char * array declaration might be better as static const
        #1554: FILE: drivers/mfd/ab8500-core.c:1554:
        +	static char *switch_off_status[] = {
    
        WARNING: char * array declaration might be better as static const
        #1563: FILE: drivers/mfd/ab8500-core.c:1563:
        +	static char *turn_on_status[] = {
    
        WARNING: sizeof *ab8500 should be sizeof(*ab8500)
        #1582: FILE: drivers/mfd/ab8500-core.c:1582:
        +	ab8500 = devm_kzalloc(&pdev->dev, sizeof *ab8500, GFP_KERNEL);
    
        ERROR: space required after that close brace '}'
        #1639: FILE: drivers/mfd/ab8500-core.c:1639:
        +	}/* Configure AB8500 or AB9540 IRQ */
    
        WARNING: line over 80 characters
        #1652: FILE: drivers/mfd/ab8500-core.c:1652:
        +	ab8500->oldmask = devm_kzalloc(&pdev->dev, ab8500->mask_size, GFP_KERNEL);
    
        WARNING: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(...  to printk(KERN_CONT ...
        #1677: FILE: drivers/mfd/ab8500-core.c:1677:
        +				printk(KERN_CONT " \"%s\"",
    
        WARNING: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(...  to printk(KERN_CONT ...
        #1682: FILE: drivers/mfd/ab8500-core.c:1682:
        +		printk(KERN_CONT "\n");
    
        WARNING: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(...  to printk(KERN_CONT ...
        #1684: FILE: drivers/mfd/ab8500-core.c:1684:
        +		printk(KERN_CONT " None\n");
    
        WARNING: printk() should include KERN_ facility level
        #1695: FILE: drivers/mfd/ab8500-core.c:1695:
        +				printk("\"%s\" ", turn_on_status[i]);
    
        WARNING: printk() should include KERN_ facility level
        #1700: FILE: drivers/mfd/ab8500-core.c:1700:
        +		printk("None\n");
    
        total: 5 errors, 14 warnings, 1869 lines checked
    Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
    7ccf40b1
ab8500-core.c 44.9 KB