• Tom Parkin's avatar
    l2tp: don't BUG_ON seqfile checks in l2tp_ppp · ebb4f5e6
    Tom Parkin authored
    checkpatch advises that WARN_ON and recovery code are preferred over
    BUG_ON which crashes the kernel.
    
    l2tp_ppp has a BUG_ON check of struct seq_file's private pointer in
    pppol2tp_seq_start prior to accessing data through that pointer.
    
    Rather than crashing, we can simply bail out early and return NULL in
    order to terminate the seq file processing in much the same way as we do
    when reaching the end of tunnel/session instances to render.
    
    Retain a WARN_ON to help trace possible bugs in this area.
    Signed-off-by: default avatarTom Parkin <tparkin@katalix.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ebb4f5e6
l2tp_ppp.c 43.6 KB