• Scott Feldman's avatar
    switchdev: fix handling for drivers not supporting IPv4 fib add/del ops · af201f72
    Scott Feldman authored
    If CONFIG_NET_SWITCHDEV is enabled, but port driver does not implement
    support for IPv4 FIB add/del ops, don't fail route add/del offload
    operations.  Route adds will not be marked as OFFLOAD.  Routes will be
    installed in the kernel FIB, as usual.
    
    This was report/fixed by Florian when testing DSA driver with net-next on
    devices with L2 offload support but no L3 offload support. What he reported
    was an initial route installed from DHCP client would fail (route not
    installed to kernel FIB).  This was triggering the setting of
    ipv4.fib_offload_disabled, which would disable route offloading after the
    first failure.  So subsequent attempts to install the route would succeed.
    
    There is follow-on work/discussion to address the handling of route install
    failures, but for now, let's differentiate between no support and failed
    support.
    Reported-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: default avatarScott Feldman <sfeldma@gmail.com>
    Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    af201f72
switchdev.c 21.9 KB