• Rodrigo Vivi's avatar
    drm/i915: PSR: Mask LPSP hw tracking back again. · bb929cbc
    Rodrigo Vivi authored
    When we introduced PSR we let LPSP masked allowing us to get PSR
    independently from the audio runtime PM. However in one of the
    attempts to get PSR enabled by default one user reported one specific
    case where he would miss screen updates if scrolling the firefox in a
    Gnome environment when i915 runtime pm was enabled. So for
    this specific case that (I could never create an i-g-t test case)
    we decided to remove the LPSP mask and let HW tracking taking care of
    this case. The mask got removed later by my
    commit 09108b90 ("drm/i915: PSR: Remove Low Power HW tracking mask.")
    
    So we started depending on audio driver again, what is bad.
    
    With previous commit
    "drm/i915: PSR: Let's rely more on frontbuffer tracking."
    we transfered the PSR exit responsability totally to SW frontbuffer
    tracking. So now can safelly shut off a bit the HW tracking, or
    at least this case that makes us to depend on other drivers.
    
    v2: Update commit message since this patch by itself doesn't solve
        the bugzilla entries.
    
    v3: Another attempt to improve commit message.
    
    Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Tested-by: default avatarBrian Norris <briannorris@chromium.org>
    Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    Reviewed-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
    Reviewed-by: Damien Lespiau damien.lespiau@intel.com
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    bb929cbc
intel_psr.c 24.1 KB