• Masahiro Yamada's avatar
    kbuild: use -- separater intead of $(filter-out ...) for cc-cross-prefix · d4a74bbf
    Masahiro Yamada authored
    arch/mips/Makefile passes prefixes that start with '-' to cc-cross-prefix
    when $(tool-archpref) evaluates to the empty string.
    
    They are filtered-out before the $(shell ...) invocation. Otherwise,
    'command -v' would be confused.
    
      $ command -v -linux-gcc
      bash: command: -l: invalid option
      command: usage: command [-pVv] command [arg ...]
    
    Since commit 913ab978 ("kbuild: use more portable 'command -v' for
    cc-cross-prefix"), cc-cross-prefix throws away the stderr output, so
    the console is not polluted in any way.
    
    This is not a big deal in practice, but I see a slightly better taste
    in adding '--' to teach it that '-linux-gcc' is an argument instead of
    a command option.
    
    This will cause extra forking of subshell, but it will not be noticeable
    performance regression.
    Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    d4a74bbf
Kbuild.include 12.5 KB