• Arnaldo Carvalho de Melo's avatar
    perf evlist: Handle -EINVAL for sample_freq > max_sample_rate in strerror_open() · d9aade7f
    Arnaldo Carvalho de Melo authored
    When running the "code reading" test we get:
    
      # perf test -v "code reading" 2>&1 | tail -5
      Parsing event 'cycles:u'
      perf_evlist__open failed
      test child finished with -1
      ---- end ----
      Test object code reading: FAILED!
      #
    
    And with -vv we get the errno value, -22, i.e. -EINVAL, but we can do
    better and handle the case at hand, with this patch it becomes:
    
      # perf test -v "code reading" 2>&1 | tail -7
      perf_evlist__open() failed!
      Error: Invalid argument.
      Hint:  Check /proc/sys/kernel/perf_event_max_sample_rate.
      Hint:  The current value is 1000 and 4000 is being requested.
      test child finished with -1
      ---- end ----
      Test object code reading: FAILED!
      #
    
    Next patch will make this 'perf test' entry to use perf_evlist__strerror()
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Steven Noonan <steven@uplinklabs.net>
    Cc: Wang Nan <wangnan0@huawei.com>
    Link: http://lkml.kernel.org/n/tip-i31ai6kfefn75eapejjokfhc@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    d9aade7f
evlist.c 40.2 KB