• Eric Biggers's avatar
    crypto: adiantum - initialize crypto_spawn::inst · 6db43410
    Eric Biggers authored
    crypto_grab_*() doesn't set crypto_spawn::inst, so templates must set it
    beforehand.  Otherwise it will be left NULL, which causes a crash in
    certain cases where algorithms are dynamically loaded/unloaded.  E.g.
    with CONFIG_CRYPTO_CHACHA20_X86_64=m, the following caused a crash:
    
        insmod chacha-x86_64.ko
        python -c 'import socket; socket.socket(socket.AF_ALG, 5, 0).bind(("skcipher", "adiantum(xchacha12,aes)"))'
        rmmod chacha-x86_64.ko
        python -c 'import socket; socket.socket(socket.AF_ALG, 5, 0).bind(("skcipher", "adiantum(xchacha12,aes)"))'
    
    Fixes: 059c2a4d ("crypto: adiantum - add Adiantum support")
    Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    6db43410
adiantum.c 20.8 KB