• Jason Wessel's avatar
    timekeeping: Fix overflow in rawtime tv_nsec on 32 bit archs · deda2e81
    Jason Wessel authored
    The tv_nsec is a long and when added to the shifted interval it can wrap
    and become negative which later causes looping problems in the
    getrawmonotonic().  The edge case occurs when the system has slept for
    a short period of time of ~2 seconds.
    
    A trace printk of the values in this patch illustrate the problem:
    
    ftrace time stamp: log
    43.716079: logarithmic_accumulation: raw: 3d0913 tv_nsec d687faa
    43.718513: logarithmic_accumulation: raw: 3d0913 tv_nsec da588bd
    43.722161: logarithmic_accumulation: raw: 3d0913 tv_nsec de291d0
    46.349925: logarithmic_accumulation: raw: 7a122600 tv_nsec e1f9ae3b
    46.349930: logarithmic_accumulation: raw: 1e848980 tv_nsec 8831c0e3
    
    The kernel starts looping at 46.349925 in the getrawmonotonic() due to
    the negative value from adding the raw value to tv_nsec.
    
    A simple solution is to accumulate into a u64, and then normalize it
    to a timespec_t.
    Signed-off-by: default avatarJason Wessel <jason.wessel@windriver.com>
     [ Reworked variable names and simplified some of the code. - John ]
    Signed-off-by: default avatarJohn Stultz <johnstul@us.ibm.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    deda2e81
timekeeping.c 22.9 KB