• Suresh Siddha's avatar
    x64, apic: use generic apic_write() for ack_APIC_irq() · df1be437
    Suresh Siddha authored
    I tested tip/master and found an issue (patch attached)
    for x2apic support. This is not because of the recent merges we had, but
    because of something(where we still access memory based interface after
    enabling x2apic mode) that slipped through my earlier tests.
    
    Probably it is a good idea to unmap the memory mapped interface, once we switch
    to x2apic mode. That will catch the issues much earlier. I will
    post another patch for this.
    
    ack_APIC_irq() is used at too many generic places (and not just during
    irq_chip handling!) to use the native_apic_mem_write(). For ex, this will
    break x2apic based systems.
    
    Fix ack_APIC_irq() to use the generic apic_write() even for 64-bit.
    Signed-off-by: default avatarSuresh Siddha <suresh.b.siddha@intel.com>
    Cc: suresh.b.siddha@intel.com
    Cc: yong.y.wang@linux.intel.com
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    df1be437
apic.h 4.29 KB