• Oleg Nesterov's avatar
    uprobes: Introduce uprobe->register_rwsem · e591c8d7
    Oleg Nesterov authored
    Introduce uprobe->register_rwsem. It is taken for writing around
    __uprobe_register/unregister.
    
    Change handler_chain() to use this sem rather than consumer_rwsem.
    
    The main reason for this change is that we have the nasty problem
    with mmap_sem/consumer_rwsem dependency. filter_chain() needs to
    protect uprobe->consumers like handler_chain(), but they can not
    use the same lock. filter_chain() can be called under ->mmap_sem
    (currently this is always true), but we want to allow ->handler()
    to play with the probed task's memory, and this needs ->mmap_sem.
    
    Alternatively we could use srcu, but synchronize_srcu() is very
    slow and ->register_rwsem allows us to do more. In particular, we
    can teach handler_chain() to do remove_breakpoint() if this bp is
    "nacked" by all consumers, we know that we can't race with the
    new consumer which does uprobe_register().
    
    See also the next patches. uprobes_mutex[] is almost ready to die.
    Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
    Acked-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
    e591c8d7
uprobes.c 39.2 KB