Commit 00b15628 authored by Bojan Prtvar's avatar Bojan Prtvar Committed by Jiri Kosina

HID: prodikeys: kfree() NULL pointer cleanup

No need for freeing pm in case when it's not allocated.
Reported-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarBojan Prtvar <prtvar.b@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 6371fe54
...@@ -816,7 +816,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id) ...@@ -816,7 +816,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
if (pm == NULL) { if (pm == NULL) {
hid_err(hdev, "can't alloc descriptor\n"); hid_err(hdev, "can't alloc descriptor\n");
ret = -ENOMEM; ret = -ENOMEM;
goto err_free; goto err_free_pk;
} }
pm->pk = pk; pm->pk = pk;
...@@ -849,10 +849,10 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id) ...@@ -849,10 +849,10 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
err_stop: err_stop:
hid_hw_stop(hdev); hid_hw_stop(hdev);
err_free: err_free:
if (pm != NULL)
kfree(pm); kfree(pm);
err_free_pk:
kfree(pk); kfree(pk);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment