Commit 03c42001 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab

[media] tuners/xc2028: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>
Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 36628731
...@@ -870,7 +870,7 @@ static int check_firmware(struct dvb_frontend *fe, unsigned int type, ...@@ -870,7 +870,7 @@ static int check_firmware(struct dvb_frontend *fe, unsigned int type,
} }
read_not_reliable: read_not_reliable:
memcpy(&priv->cur_fw, &new_fw, sizeof(priv->cur_fw)); priv->cur_fw = new_fw;
/* /*
* By setting BASE in cur_fw.type only after successfully loading all * By setting BASE in cur_fw.type only after successfully loading all
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment