Commit 0557344e authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: ni_mio_common: fix local var for 32-bit read

The local variable 'd' is used to read a 32-bit register. One branch of
the code shifts the register value 16 bits to the right to get the high
16-bits. Change the type of the local variable so that this shift works
correctly.

Reported by: coverity
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ae2aef64
...@@ -2108,7 +2108,7 @@ static int ni_ai_insn_read(struct comedi_device *dev, ...@@ -2108,7 +2108,7 @@ static int ni_ai_insn_read(struct comedi_device *dev,
unsigned int mask = (s->maxdata + 1) >> 1; unsigned int mask = (s->maxdata + 1) >> 1;
int i, n; int i, n;
unsigned signbits; unsigned signbits;
unsigned short d; unsigned int d;
unsigned long dl; unsigned long dl;
ni_load_channelgain_list(dev, s, 1, &insn->chanspec); ni_load_channelgain_list(dev, s, 1, &insn->chanspec);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment