Commit 05ba999f authored by Andrew Duggan's avatar Andrew Duggan Committed by Jiri Kosina

HID: rmi: disable dribble packets on Synaptics touchpads

When a finger is lifted from a Synaptics touchpad the firmware will continue
to interrupts for up to a second. These additional interrupts are know and
dribble interrupts. Since the data read from the touchpad does not change
the input subsystem only reports a single event. This makes the servicing of
dribble interrupts on Linux unnecessary. This patch simply disables dribble
interupts when configuring the touchpad.
Signed-off-by: default avatarAndrew Duggan <aduggan@synaptics.com>
Tested-by: default avatarGabriele Mazzotta <gabriele.mzt@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent dd8df284
...@@ -751,6 +751,7 @@ static int rmi_populate_f11(struct hid_device *hdev) ...@@ -751,6 +751,7 @@ static int rmi_populate_f11(struct hid_device *hdev)
bool has_gestures; bool has_gestures;
bool has_rel; bool has_rel;
bool has_data40 = false; bool has_data40 = false;
bool has_dribble = false;
unsigned x_size, y_size; unsigned x_size, y_size;
u16 query_offset; u16 query_offset;
...@@ -792,6 +793,14 @@ static int rmi_populate_f11(struct hid_device *hdev) ...@@ -792,6 +793,14 @@ static int rmi_populate_f11(struct hid_device *hdev)
has_rel = !!(buf[0] & BIT(3)); has_rel = !!(buf[0] & BIT(3));
has_gestures = !!(buf[0] & BIT(5)); has_gestures = !!(buf[0] & BIT(5));
ret = rmi_read(hdev, data->f11.query_base_addr + 5, buf);
if (ret) {
hid_err(hdev, "can not get absolute data sources: %d.\n", ret);
return ret;
}
has_dribble = !!(buf[0] & BIT(4));
/* /*
* At least 4 queries are guaranteed to be present in F11 * At least 4 queries are guaranteed to be present in F11
* +1 for query 5 which is present since absolute events are * +1 for query 5 which is present since absolute events are
...@@ -908,6 +917,16 @@ static int rmi_populate_f11(struct hid_device *hdev) ...@@ -908,6 +917,16 @@ static int rmi_populate_f11(struct hid_device *hdev)
data->max_x = buf[6] | (buf[7] << 8); data->max_x = buf[6] | (buf[7] << 8);
data->max_y = buf[8] | (buf[9] << 8); data->max_y = buf[8] | (buf[9] << 8);
if (has_dribble) {
buf[0] = buf[0] & ~BIT(6);
ret = rmi_write(hdev, data->f11.control_base_addr, buf);
if (ret) {
hid_err(hdev, "can not write to control reg 0: %d.\n",
ret);
return ret;
}
}
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment