Commit 067756ac authored by Hariprasad Kelam's avatar Hariprasad Kelam Committed by Greg Kroah-Hartman

staging: rtl8723bs: core: Change return type of init_mlme_ext_priv

As init_mlme_ext_priv function always returns SUCCESS , We can change
return type from int to void.

Fixes below issue identified by coccicheck
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:464:5-8: Unneeded
variable: "res". Return "_SUCCESS" on line 492
Signed-off-by: default avatarHariprasad Kelam <hariprasad.kelam@gmail.com>
Link: https://lore.kernel.org/r/20190715174618.GA8947@hari-Inspiron-1545Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b21f9b83
...@@ -455,9 +455,8 @@ static u8 init_channel_set(struct adapter *padapter, u8 ChannelPlan, RT_CHANNEL_ ...@@ -455,9 +455,8 @@ static u8 init_channel_set(struct adapter *padapter, u8 ChannelPlan, RT_CHANNEL_
return chanset_size; return chanset_size;
} }
int init_mlme_ext_priv(struct adapter *padapter) void init_mlme_ext_priv(struct adapter *padapter)
{ {
int res = _SUCCESS;
struct registry_priv *pregistrypriv = &padapter->registrypriv; struct registry_priv *pregistrypriv = &padapter->registrypriv;
struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
...@@ -484,9 +483,6 @@ int init_mlme_ext_priv(struct adapter *padapter) ...@@ -484,9 +483,6 @@ int init_mlme_ext_priv(struct adapter *padapter)
#ifdef DBG_FIXED_CHAN #ifdef DBG_FIXED_CHAN
pmlmeext->fixed_chan = 0xFF; pmlmeext->fixed_chan = 0xFF;
#endif #endif
return res;
} }
void free_mlme_ext_priv(struct mlme_ext_priv *pmlmeext) void free_mlme_ext_priv(struct mlme_ext_priv *pmlmeext)
......
...@@ -535,7 +535,7 @@ struct mlme_ext_priv ...@@ -535,7 +535,7 @@ struct mlme_ext_priv
}; };
void init_mlme_default_rate_set(struct adapter *padapter); void init_mlme_default_rate_set(struct adapter *padapter);
int init_mlme_ext_priv(struct adapter *padapter); void init_mlme_ext_priv(struct adapter *padapter);
int init_hw_mlme_ext(struct adapter *padapter); int init_hw_mlme_ext(struct adapter *padapter);
void free_mlme_ext_priv (struct mlme_ext_priv *pmlmeext); void free_mlme_ext_priv (struct mlme_ext_priv *pmlmeext);
extern void init_mlme_ext_timer(struct adapter *padapter); extern void init_mlme_ext_timer(struct adapter *padapter);
......
...@@ -765,11 +765,7 @@ u8 rtw_init_drv_sw(struct adapter *padapter) ...@@ -765,11 +765,7 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
goto exit; goto exit;
} }
if (init_mlme_ext_priv(padapter) == _FAIL) { init_mlme_ext_priv(padapter);
RT_TRACE(_module_os_intfs_c_, _drv_err_, ("\n Can't init mlme_ext_priv\n"));
ret8 = _FAIL;
goto exit;
}
if (_rtw_init_xmit_priv(&padapter->xmitpriv, padapter) == _FAIL) { if (_rtw_init_xmit_priv(&padapter->xmitpriv, padapter) == _FAIL) {
DBG_871X("Can't _rtw_init_xmit_priv\n"); DBG_871X("Can't _rtw_init_xmit_priv\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment