Commit 06add777 authored by Mike Christie's avatar Mike Christie Committed by Martin K. Petersen

scsi: tcmu: misc nl code cleanup

Some misc cleanup of the nl rework patches.

1. Fix space instead of tabs use and extra newline

2. Drop initializing variables to 0 when not needed

3. Just pass the skb_buff and msg_header pointers to
   tcmu_netlink_event_send.
Signed-off-by: default avatarMike Christie <mchristi@redhat.com>
Tested-by: default avatarXiubo Li <xiubli@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9de3a1ef
...@@ -1628,11 +1628,9 @@ static int tcmu_netlink_event_init(struct tcmu_dev *udev, ...@@ -1628,11 +1628,9 @@ static int tcmu_netlink_event_init(struct tcmu_dev *udev,
static int tcmu_netlink_event_send(struct tcmu_dev *udev, static int tcmu_netlink_event_send(struct tcmu_dev *udev,
enum tcmu_genl_cmd cmd, enum tcmu_genl_cmd cmd,
struct sk_buff **buf, void **hdr) struct sk_buff *skb, void *msg_header)
{ {
int ret = 0; int ret;
struct sk_buff *skb = *buf;
void *msg_header = *hdr;
genlmsg_end(skb, msg_header); genlmsg_end(skb, msg_header);
...@@ -1662,9 +1660,8 @@ static int tcmu_send_dev_add_event(struct tcmu_dev *udev) ...@@ -1662,9 +1660,8 @@ static int tcmu_send_dev_add_event(struct tcmu_dev *udev)
&msg_header); &msg_header);
if (ret < 0) if (ret < 0)
return ret; return ret;
return tcmu_netlink_event_send(udev, TCMU_CMD_ADDED_DEVICE, &skb, return tcmu_netlink_event_send(udev, TCMU_CMD_ADDED_DEVICE, skb,
&msg_header); msg_header);
} }
static int tcmu_send_dev_remove_event(struct tcmu_dev *udev) static int tcmu_send_dev_remove_event(struct tcmu_dev *udev)
...@@ -1678,7 +1675,7 @@ static int tcmu_send_dev_remove_event(struct tcmu_dev *udev) ...@@ -1678,7 +1675,7 @@ static int tcmu_send_dev_remove_event(struct tcmu_dev *udev)
if (ret < 0) if (ret < 0)
return ret; return ret;
return tcmu_netlink_event_send(udev, TCMU_CMD_REMOVED_DEVICE, return tcmu_netlink_event_send(udev, TCMU_CMD_REMOVED_DEVICE,
&skb, &msg_header); skb, msg_header);
} }
static int tcmu_update_uio_info(struct tcmu_dev *udev) static int tcmu_update_uio_info(struct tcmu_dev *udev)
...@@ -2197,7 +2194,7 @@ static int tcmu_send_dev_config_event(struct tcmu_dev *udev, ...@@ -2197,7 +2194,7 @@ static int tcmu_send_dev_config_event(struct tcmu_dev *udev,
return ret; return ret;
} }
return tcmu_netlink_event_send(udev, TCMU_CMD_RECONFIG_DEVICE, return tcmu_netlink_event_send(udev, TCMU_CMD_RECONFIG_DEVICE,
&skb, &msg_header); skb, msg_header);
} }
...@@ -2259,7 +2256,7 @@ static int tcmu_send_dev_size_event(struct tcmu_dev *udev, u64 size) ...@@ -2259,7 +2256,7 @@ static int tcmu_send_dev_size_event(struct tcmu_dev *udev, u64 size)
return ret; return ret;
} }
return tcmu_netlink_event_send(udev, TCMU_CMD_RECONFIG_DEVICE, return tcmu_netlink_event_send(udev, TCMU_CMD_RECONFIG_DEVICE,
&skb, &msg_header); skb, msg_header);
} }
static ssize_t tcmu_dev_size_store(struct config_item *item, const char *page, static ssize_t tcmu_dev_size_store(struct config_item *item, const char *page,
...@@ -2341,7 +2338,7 @@ static int tcmu_send_emulate_write_cache(struct tcmu_dev *udev, u8 val) ...@@ -2341,7 +2338,7 @@ static int tcmu_send_emulate_write_cache(struct tcmu_dev *udev, u8 val)
return ret; return ret;
} }
return tcmu_netlink_event_send(udev, TCMU_CMD_RECONFIG_DEVICE, return tcmu_netlink_event_send(udev, TCMU_CMD_RECONFIG_DEVICE,
&skb, &msg_header); skb, msg_header);
} }
static ssize_t tcmu_emulate_write_cache_store(struct config_item *item, static ssize_t tcmu_emulate_write_cache_store(struct config_item *item,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment