Commit 0968cf51 authored by Jeff Garzik's avatar Jeff Garzik Committed by Linus Torvalds

[PATCH] firmware/dcdbas: fix bug in error cleanup

The error path path mistakenly called sysfs_create_group() rather than
sysfs_remove_group().  They take the same arguments, so it's easy to
cut-n-paste such a bug.
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 15e541fe
...@@ -559,7 +559,7 @@ static int __devinit dcdbas_probe(struct platform_device *dev) ...@@ -559,7 +559,7 @@ static int __devinit dcdbas_probe(struct platform_device *dev)
while (--i >= 0) while (--i >= 0)
sysfs_remove_bin_file(&dev->dev.kobj, sysfs_remove_bin_file(&dev->dev.kobj,
dcdbas_bin_attrs[i]); dcdbas_bin_attrs[i]);
sysfs_create_group(&dev->dev.kobj, &dcdbas_attr_group); sysfs_remove_group(&dev->dev.kobj, &dcdbas_attr_group);
return error; return error;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment