Commit 09da5916 authored by Jan Blunck's avatar Jan Blunck Committed by Linus Torvalds

Use path_put() in a few places instead of {mnt,d}put()

Use path_put() in a few places instead of {mnt,d}put()
Signed-off-by: default avatarJan Blunck <jblunck@suse.de>
Signed-off-by: default avatarAndreas Gruenbacher <agruen@suse.de>
Acked-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1d957f9b
...@@ -235,8 +235,7 @@ static void *afs_mntpt_follow_link(struct dentry *dentry, struct nameidata *nd) ...@@ -235,8 +235,7 @@ static void *afs_mntpt_follow_link(struct dentry *dentry, struct nameidata *nd)
err = do_add_mount(newmnt, nd, MNT_SHRINKABLE, &afs_vfsmounts); err = do_add_mount(newmnt, nd, MNT_SHRINKABLE, &afs_vfsmounts);
switch (err) { switch (err) {
case 0: case 0:
dput(nd->path.dentry); path_put(&nd->path);
mntput(nd->path.mnt);
nd->path.mnt = newmnt; nd->path.mnt = newmnt;
nd->path.dentry = dget(newmnt->mnt_root); nd->path.dentry = dget(newmnt->mnt_root);
schedule_delayed_work(&afs_mntpt_expiry_timer, schedule_delayed_work(&afs_mntpt_expiry_timer,
......
...@@ -625,8 +625,7 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata ...@@ -625,8 +625,7 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata
if (dentry->d_inode->i_op->put_link) if (dentry->d_inode->i_op->put_link)
dentry->d_inode->i_op->put_link(dentry, nd, cookie); dentry->d_inode->i_op->put_link(dentry, nd, cookie);
} }
dput(dentry); path_put(path);
mntput(path->mnt);
return error; return error;
} }
...@@ -1033,8 +1032,7 @@ static int link_path_walk(const char *name, struct nameidata *nd) ...@@ -1033,8 +1032,7 @@ static int link_path_walk(const char *name, struct nameidata *nd)
result = __link_path_walk(name, nd); result = __link_path_walk(name, nd);
} }
dput(save.path.dentry); path_put(&save.path);
mntput(save.path.mnt);
return result; return result;
} }
...@@ -1056,8 +1054,7 @@ static int __emul_lookup_dentry(const char *name, struct nameidata *nd) ...@@ -1056,8 +1054,7 @@ static int __emul_lookup_dentry(const char *name, struct nameidata *nd)
if (!nd->path.dentry->d_inode || if (!nd->path.dentry->d_inode ||
S_ISDIR(nd->path.dentry->d_inode->i_mode)) { S_ISDIR(nd->path.dentry->d_inode->i_mode)) {
struct dentry *old_dentry = nd->path.dentry; struct path old_path = nd->path;
struct vfsmount *old_mnt = nd->path.mnt;
struct qstr last = nd->last; struct qstr last = nd->last;
int last_type = nd->last_type; int last_type = nd->last_type;
struct fs_struct *fs = current->fs; struct fs_struct *fs = current->fs;
...@@ -1073,14 +1070,12 @@ static int __emul_lookup_dentry(const char *name, struct nameidata *nd) ...@@ -1073,14 +1070,12 @@ static int __emul_lookup_dentry(const char *name, struct nameidata *nd)
read_unlock(&fs->lock); read_unlock(&fs->lock);
if (path_walk(name, nd) == 0) { if (path_walk(name, nd) == 0) {
if (nd->path.dentry->d_inode) { if (nd->path.dentry->d_inode) {
dput(old_dentry); path_put(&old_path);
mntput(old_mnt);
return 1; return 1;
} }
path_put(&nd->path); path_put(&nd->path);
} }
nd->path.dentry = old_dentry; nd->path = old_path;
nd->path.mnt = old_mnt;
nd->last = last; nd->last = last;
nd->last_type = last_type; nd->last_type = last_type;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment