Commit 0b24a0bb authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Marc Zyngier

irqdomain: Re-use DEFINE_SHOW_ATTRIBUTE() macro

...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 2d02424e
...@@ -1726,25 +1726,14 @@ static int irq_domain_debug_show(struct seq_file *m, void *p) ...@@ -1726,25 +1726,14 @@ static int irq_domain_debug_show(struct seq_file *m, void *p)
irq_domain_debug_show_one(m, d, 0); irq_domain_debug_show_one(m, d, 0);
return 0; return 0;
} }
DEFINE_SHOW_ATTRIBUTE(irq_domain_debug);
static int irq_domain_debug_open(struct inode *inode, struct file *file)
{
return single_open(file, irq_domain_debug_show, inode->i_private);
}
static const struct file_operations dfs_domain_ops = {
.open = irq_domain_debug_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
static void debugfs_add_domain_dir(struct irq_domain *d) static void debugfs_add_domain_dir(struct irq_domain *d)
{ {
if (!d->name || !domain_dir || d->debugfs_file) if (!d->name || !domain_dir || d->debugfs_file)
return; return;
d->debugfs_file = debugfs_create_file(d->name, 0444, domain_dir, d, d->debugfs_file = debugfs_create_file(d->name, 0444, domain_dir, d,
&dfs_domain_ops); &irq_domain_debug_fops);
} }
static void debugfs_remove_domain_dir(struct irq_domain *d) static void debugfs_remove_domain_dir(struct irq_domain *d)
...@@ -1760,7 +1749,8 @@ void __init irq_domain_debugfs_init(struct dentry *root) ...@@ -1760,7 +1749,8 @@ void __init irq_domain_debugfs_init(struct dentry *root)
if (!domain_dir) if (!domain_dir)
return; return;
debugfs_create_file("default", 0444, domain_dir, NULL, &dfs_domain_ops); debugfs_create_file("default", 0444, domain_dir, NULL,
&irq_domain_debug_fops);
mutex_lock(&irq_domain_mutex); mutex_lock(&irq_domain_mutex);
list_for_each_entry(d, &irq_domain_list, link) list_for_each_entry(d, &irq_domain_list, link)
debugfs_add_domain_dir(d); debugfs_add_domain_dir(d);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment