Commit 0b8c8219 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: hda - Cancel probe work instead of flush at remove

The commit [991f86d7: ALSA: hda - Flush the pending probe work at
remove] introduced the sync of async probe work at remove for fixing
the race.  However, this may lead to another hangup when the module
removal is performed quickly before starting the probe work, because
it issues flush_work() and it's blocked forever.

The workaround is to use cancel_work_sync() instead of flush_work()
there.

Fixes: 991f86d7 ('ALSA: hda - Flush the pending probe work at remove')
Cc: <stable@vger.kernel.org> # v3.17+
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent d99a36f4
...@@ -2168,10 +2168,10 @@ static void azx_remove(struct pci_dev *pci) ...@@ -2168,10 +2168,10 @@ static void azx_remove(struct pci_dev *pci)
struct hda_intel *hda; struct hda_intel *hda;
if (card) { if (card) {
/* flush the pending probing work */ /* cancel the pending probing work */
chip = card->private_data; chip = card->private_data;
hda = container_of(chip, struct hda_intel, chip); hda = container_of(chip, struct hda_intel, chip);
flush_work(&hda->probe_work); cancel_work_sync(&hda->probe_work);
snd_card_free(card); snd_card_free(card);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment