Commit 0e65967e authored by Allan Stephens's avatar Allan Stephens Committed by David S. Miller

tipc: cleanup various cosmetic whitespace issues

Cleans up TIPC's source code to eliminate deviations from generally
accepted coding conventions relating to leading/trailing white space
and white space around commas, braces, cases, and sizeof.

These changes are purely cosmetic and do not alter the operation of TIPC
in any way.
Signed-off-by: default avatarAllan Stephens <Allan.Stephens@windriver.com>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 25860c3b
...@@ -137,7 +137,7 @@ static inline unsigned int tipc_node(__u32 addr) ...@@ -137,7 +137,7 @@ static inline unsigned int tipc_node(__u32 addr)
#define TIPC_SUB_SINGLE_EVT 0x10 /* expire after first event */ #define TIPC_SUB_SINGLE_EVT 0x10 /* expire after first event */
#endif #endif
#define TIPC_WAIT_FOREVER ~0 /* timeout for permanent subscription */ #define TIPC_WAIT_FOREVER (~0) /* timeout for permanent subscription */
struct tipc_subscr { struct tipc_subscr {
struct tipc_name_seq seq; /* name sequence of interest */ struct tipc_name_seq seq; /* name sequence of interest */
......
...@@ -379,8 +379,7 @@ struct tipc_genlmsghdr { ...@@ -379,8 +379,7 @@ struct tipc_genlmsghdr {
* that follows. * that follows.
*/ */
struct tipc_cfg_msg_hdr struct tipc_cfg_msg_hdr {
{
__be32 tcm_len; /* Message length (including header) */ __be32 tcm_len; /* Message length (including header) */
__be16 tcm_type; /* Command type */ __be16 tcm_type; /* Command type */
__be16 tcm_flags; /* Additional flags */ __be16 tcm_flags; /* Additional flags */
......
...@@ -428,7 +428,7 @@ void tipc_bclink_recv_pkt(struct sk_buff *buf) ...@@ -428,7 +428,7 @@ void tipc_bclink_recv_pkt(struct sk_buff *buf)
static int rx_count = 0; static int rx_count = 0;
#endif #endif
struct tipc_msg *msg = buf_msg(buf); struct tipc_msg *msg = buf_msg(buf);
struct tipc_node* node = tipc_node_find(msg_prevnode(msg)); struct tipc_node *node = tipc_node_find(msg_prevnode(msg));
u32 next_in; u32 next_in;
u32 seqno; u32 seqno;
struct sk_buff *deferred; struct sk_buff *deferred;
......
...@@ -322,8 +322,7 @@ struct sk_buff *tipc_cfg_do_cmd(u32 orig_node, u16 cmd, const void *request_area ...@@ -322,8 +322,7 @@ struct sk_buff *tipc_cfg_do_cmd(u32 orig_node, u16 cmd, const void *request_area
} else if (!tipc_remote_management) { } else if (!tipc_remote_management) {
rep_tlv_buf = tipc_cfg_reply_error_string(TIPC_CFG_NO_REMOTE); rep_tlv_buf = tipc_cfg_reply_error_string(TIPC_CFG_NO_REMOTE);
goto exit; goto exit;
} } else if (cmd >= 0x4000) {
else if (cmd >= 0x4000) {
u32 domain = 0; u32 domain = 0;
if ((tipc_nametbl_translate(TIPC_ZM_SRV, 0, &domain) == 0) || if ((tipc_nametbl_translate(TIPC_ZM_SRV, 0, &domain) == 0) ||
......
...@@ -130,7 +130,7 @@ void tipc_disc_recv_msg(struct sk_buff *buf, struct bearer *b_ptr) ...@@ -130,7 +130,7 @@ void tipc_disc_recv_msg(struct sk_buff *buf, struct bearer *b_ptr)
u32 net_id = msg_bc_netid(msg); u32 net_id = msg_bc_netid(msg);
u32 type = msg_type(msg); u32 type = msg_type(msg);
msg_get_media_addr(msg,&media_addr); msg_get_media_addr(msg, &media_addr);
buf_discard(buf); buf_discard(buf);
if (net_id != tipc_net_id) if (net_id != tipc_net_id)
......
...@@ -144,7 +144,7 @@ static int enable_bearer(struct tipc_bearer *tb_ptr) ...@@ -144,7 +144,7 @@ static int enable_bearer(struct tipc_bearer *tb_ptr)
/* Find device with specified name */ /* Find device with specified name */
for_each_netdev(&init_net, pdev){ for_each_netdev(&init_net, pdev) {
if (!strncmp(pdev->name, driver_name, IFNAMSIZ)) { if (!strncmp(pdev->name, driver_name, IFNAMSIZ)) {
dev = pdev; dev = pdev;
break; break;
...@@ -155,7 +155,8 @@ static int enable_bearer(struct tipc_bearer *tb_ptr) ...@@ -155,7 +155,8 @@ static int enable_bearer(struct tipc_bearer *tb_ptr)
/* Find Ethernet bearer for device (or create one) */ /* Find Ethernet bearer for device (or create one) */
for (;(eb_ptr != stop) && eb_ptr->dev && (eb_ptr->dev != dev); eb_ptr++); while ((eb_ptr != stop) && eb_ptr->dev && (eb_ptr->dev != dev))
eb_ptr++;
if (eb_ptr == stop) if (eb_ptr == stop)
return -EDQUOT; return -EDQUOT;
if (!eb_ptr->dev) { if (!eb_ptr->dev) {
......
...@@ -977,8 +977,7 @@ static int link_send_buf_fast(struct link *l_ptr, struct sk_buff *buf, ...@@ -977,8 +977,7 @@ static int link_send_buf_fast(struct link *l_ptr, struct sk_buff *buf,
l_ptr->next_out = buf; l_ptr->next_out = buf;
return res; return res;
} }
} } else
else
*used_max_pkt = l_ptr->max_pkt; *used_max_pkt = l_ptr->max_pkt;
} }
return tipc_link_send_buf(l_ptr, buf); /* All other cases */ return tipc_link_send_buf(l_ptr, buf); /* All other cases */
...@@ -1132,10 +1131,10 @@ static int link_send_sections_long(struct port *sender, ...@@ -1132,10 +1131,10 @@ static int link_send_sections_long(struct port *sender,
struct tipc_node *node; struct tipc_node *node;
struct tipc_msg *hdr = &sender->publ.phdr; struct tipc_msg *hdr = &sender->publ.phdr;
u32 dsz = msg_data_sz(hdr); u32 dsz = msg_data_sz(hdr);
u32 max_pkt,fragm_sz,rest; u32 max_pkt, fragm_sz, rest;
struct tipc_msg fragm_hdr; struct tipc_msg fragm_hdr;
struct sk_buff *buf,*buf_chain,*prev; struct sk_buff *buf, *buf_chain, *prev;
u32 fragm_crs,fragm_rest,hsz,sect_rest; u32 fragm_crs, fragm_rest, hsz, sect_rest;
const unchar *sect_crs; const unchar *sect_crs;
int curr_sect; int curr_sect;
u32 fragm_no; u32 fragm_no;
...@@ -1212,7 +1211,7 @@ static int link_send_sections_long(struct port *sender, ...@@ -1212,7 +1211,7 @@ static int link_send_sections_long(struct port *sender,
/* Initiate new fragment: */ /* Initiate new fragment: */
if (rest <= fragm_sz) { if (rest <= fragm_sz) {
fragm_sz = rest; fragm_sz = rest;
msg_set_type(&fragm_hdr,LAST_FRAGMENT); msg_set_type(&fragm_hdr, LAST_FRAGMENT);
} else { } else {
msg_set_type(&fragm_hdr, FRAGMENT); msg_set_type(&fragm_hdr, FRAGMENT);
} }
...@@ -1229,8 +1228,7 @@ static int link_send_sections_long(struct port *sender, ...@@ -1229,8 +1228,7 @@ static int link_send_sections_long(struct port *sender,
fragm_crs = INT_H_SIZE; fragm_crs = INT_H_SIZE;
fragm_rest = fragm_sz; fragm_rest = fragm_sz;
} }
} } while (rest > 0);
while (rest > 0);
/* /*
* Now we have a buffer chain. Select a link and check * Now we have a buffer chain. Select a link and check
...@@ -1333,7 +1331,7 @@ u32 tipc_link_push_packet(struct link *l_ptr) ...@@ -1333,7 +1331,7 @@ u32 tipc_link_push_packet(struct link *l_ptr)
buf = l_ptr->proto_msg_queue; buf = l_ptr->proto_msg_queue;
if (buf) { if (buf) {
msg_set_ack(buf_msg(buf), mod(l_ptr->next_in_no - 1)); msg_set_ack(buf_msg(buf), mod(l_ptr->next_in_no - 1));
msg_set_bcast_ack(buf_msg(buf),l_ptr->owner->bclink.last_in); msg_set_bcast_ack(buf_msg(buf), l_ptr->owner->bclink.last_in);
if (tipc_bearer_send(l_ptr->b_ptr, buf, &l_ptr->media_addr)) { if (tipc_bearer_send(l_ptr->b_ptr, buf, &l_ptr->media_addr)) {
l_ptr->unacked_window = 0; l_ptr->unacked_window = 0;
buf_discard(buf); buf_discard(buf);
...@@ -1847,8 +1845,7 @@ u32 tipc_link_defer_pkt(struct sk_buff **head, ...@@ -1847,8 +1845,7 @@ u32 tipc_link_defer_pkt(struct sk_buff **head,
} }
prev = crs; prev = crs;
crs = crs->next; crs = crs->next;
} } while (crs);
while (crs);
/* Message is a duplicate of an existing message */ /* Message is a duplicate of an existing message */
...@@ -2215,11 +2212,11 @@ void tipc_link_changeover(struct link *l_ptr) ...@@ -2215,11 +2212,11 @@ void tipc_link_changeover(struct link *l_ptr)
if ((msg_user(msg) == MSG_BUNDLER) && split_bundles) { if ((msg_user(msg) == MSG_BUNDLER) && split_bundles) {
struct tipc_msg *m = msg_get_wrapped(msg); struct tipc_msg *m = msg_get_wrapped(msg);
unchar* pos = (unchar*)m; unchar *pos = (unchar *)m;
msgcount = msg_msgcnt(msg); msgcount = msg_msgcnt(msg);
while (msgcount--) { while (msgcount--) {
msg_set_seqno(m,msg_seqno(msg)); msg_set_seqno(m, msg_seqno(msg));
tipc_link_tunnel(l_ptr, &tunnel_hdr, m, tipc_link_tunnel(l_ptr, &tunnel_hdr, m,
msg_link_selector(m)); msg_link_selector(m));
pos += align(msg_size(m)); pos += align(msg_size(m));
...@@ -2321,7 +2318,7 @@ static int link_recv_changeover_msg(struct link **l_ptr, ...@@ -2321,7 +2318,7 @@ static int link_recv_changeover_msg(struct link **l_ptr,
if (msg_typ == DUPLICATE_MSG) { if (msg_typ == DUPLICATE_MSG) {
if (less(msg_seqno(msg), mod(dest_link->next_in_no))) if (less(msg_seqno(msg), mod(dest_link->next_in_no)))
goto exit; goto exit;
*buf = buf_extract(tunnel_buf,INT_H_SIZE); *buf = buf_extract(tunnel_buf, INT_H_SIZE);
if (*buf == NULL) { if (*buf == NULL) {
warn("Link changeover error, duplicate msg dropped\n"); warn("Link changeover error, duplicate msg dropped\n");
goto exit; goto exit;
...@@ -2552,8 +2549,8 @@ int tipc_link_recv_fragment(struct sk_buff **pending, struct sk_buff **fb, ...@@ -2552,8 +2549,8 @@ int tipc_link_recv_fragment(struct sk_buff **pending, struct sk_buff **fb,
/* Prepare buffer for subsequent fragments. */ /* Prepare buffer for subsequent fragments. */
set_long_msg_seqno(pbuf, long_msg_seq_no); set_long_msg_seqno(pbuf, long_msg_seq_no);
set_fragm_size(pbuf,fragm_sz); set_fragm_size(pbuf, fragm_sz);
set_expected_frags(pbuf,exp_fragm_cnt - 1); set_expected_frags(pbuf, exp_fragm_cnt - 1);
} else { } else {
warn("Link unable to reassemble fragmented message\n"); warn("Link unable to reassemble fragmented message\n");
} }
...@@ -2580,7 +2577,7 @@ int tipc_link_recv_fragment(struct sk_buff **pending, struct sk_buff **fb, ...@@ -2580,7 +2577,7 @@ int tipc_link_recv_fragment(struct sk_buff **pending, struct sk_buff **fb,
*m = buf_msg(pbuf); *m = buf_msg(pbuf);
return 1; return 1;
} }
set_expected_frags(pbuf,exp_frags); set_expected_frags(pbuf, exp_frags);
return 0; return 0;
} }
buf_discard(fbuf); buf_discard(fbuf);
......
...@@ -229,8 +229,8 @@ struct sk_buff *tipc_link_cmd_reset_stats(const void *req_tlv_area, int req_tlv_ ...@@ -229,8 +229,8 @@ struct sk_buff *tipc_link_cmd_reset_stats(const void *req_tlv_area, int req_tlv_
void tipc_link_reset(struct link *l_ptr); void tipc_link_reset(struct link *l_ptr);
int tipc_link_send(struct sk_buff *buf, u32 dest, u32 selector); int tipc_link_send(struct sk_buff *buf, u32 dest, u32 selector);
int tipc_link_send_buf(struct link *l_ptr, struct sk_buff *buf); int tipc_link_send_buf(struct link *l_ptr, struct sk_buff *buf);
u32 tipc_link_get_max_pkt(u32 dest,u32 selector); u32 tipc_link_get_max_pkt(u32 dest, u32 selector);
int tipc_link_send_sections_fast(struct port* sender, int tipc_link_send_sections_fast(struct port *sender,
struct iovec const *msg_sect, struct iovec const *msg_sect,
const u32 num_sect, const u32 num_sect,
u32 destnode); u32 destnode);
......
...@@ -91,7 +91,7 @@ int tipc_msg_calc_data_size(struct iovec const *msg_sect, u32 num_sect) ...@@ -91,7 +91,7 @@ int tipc_msg_calc_data_size(struct iovec const *msg_sect, u32 num_sect)
int tipc_msg_build(struct tipc_msg *hdr, int tipc_msg_build(struct tipc_msg *hdr,
struct iovec const *msg_sect, u32 num_sect, struct iovec const *msg_sect, u32 num_sect,
int max_size, int usrmem, struct sk_buff** buf) int max_size, int usrmem, struct sk_buff **buf)
{ {
int dsz, sz, hsz, pos, res, cnt; int dsz, sz, hsz, pos, res, cnt;
...@@ -161,10 +161,10 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str) ...@@ -161,10 +161,10 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str)
tipc_printf(buf, "LAST:"); tipc_printf(buf, "LAST:");
break; break;
default: default:
tipc_printf(buf, "UNKNOWN:%x",msg_type(msg)); tipc_printf(buf, "UNKNOWN:%x", msg_type(msg));
} }
tipc_printf(buf, "NO(%u/%u):",msg_long_msgno(msg), tipc_printf(buf, "NO(%u/%u):", msg_long_msgno(msg),
msg_fragm_no(msg)); msg_fragm_no(msg));
break; break;
case TIPC_LOW_IMPORTANCE: case TIPC_LOW_IMPORTANCE:
...@@ -190,7 +190,7 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str) ...@@ -190,7 +190,7 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str)
tipc_printf(buf, "DIR:"); tipc_printf(buf, "DIR:");
break; break;
default: default:
tipc_printf(buf, "UNKNOWN TYPE %u",msg_type(msg)); tipc_printf(buf, "UNKNOWN TYPE %u", msg_type(msg));
} }
if (msg_routed(msg) && !msg_non_seq(msg)) if (msg_routed(msg) && !msg_non_seq(msg))
tipc_printf(buf, "ROUT:"); tipc_printf(buf, "ROUT:");
...@@ -208,7 +208,7 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str) ...@@ -208,7 +208,7 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str)
tipc_printf(buf, "WDRW:"); tipc_printf(buf, "WDRW:");
break; break;
default: default:
tipc_printf(buf, "UNKNOWN:%x",msg_type(msg)); tipc_printf(buf, "UNKNOWN:%x", msg_type(msg));
} }
if (msg_routed(msg)) if (msg_routed(msg))
tipc_printf(buf, "ROUT:"); tipc_printf(buf, "ROUT:");
...@@ -227,39 +227,39 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str) ...@@ -227,39 +227,39 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str)
break; break;
case CONN_ACK: case CONN_ACK:
tipc_printf(buf, "CONN_ACK:"); tipc_printf(buf, "CONN_ACK:");
tipc_printf(buf, "ACK(%u):",msg_msgcnt(msg)); tipc_printf(buf, "ACK(%u):", msg_msgcnt(msg));
break; break;
default: default:
tipc_printf(buf, "UNKNOWN TYPE:%x",msg_type(msg)); tipc_printf(buf, "UNKNOWN TYPE:%x", msg_type(msg));
} }
if (msg_routed(msg)) if (msg_routed(msg))
tipc_printf(buf, "ROUT:"); tipc_printf(buf, "ROUT:");
if (msg_reroute_cnt(msg)) if (msg_reroute_cnt(msg))
tipc_printf(buf, "REROUTED(%u):",msg_reroute_cnt(msg)); tipc_printf(buf, "REROUTED(%u):", msg_reroute_cnt(msg));
break; break;
case LINK_PROTOCOL: case LINK_PROTOCOL:
tipc_printf(buf, "PROT:TIM(%u):",msg_timestamp(msg)); tipc_printf(buf, "PROT:TIM(%u):", msg_timestamp(msg));
switch (msg_type(msg)) { switch (msg_type(msg)) {
case STATE_MSG: case STATE_MSG:
tipc_printf(buf, "STATE:"); tipc_printf(buf, "STATE:");
tipc_printf(buf, "%s:",msg_probe(msg) ? "PRB" :""); tipc_printf(buf, "%s:", msg_probe(msg) ? "PRB" : "");
tipc_printf(buf, "NXS(%u):",msg_next_sent(msg)); tipc_printf(buf, "NXS(%u):", msg_next_sent(msg));
tipc_printf(buf, "GAP(%u):",msg_seq_gap(msg)); tipc_printf(buf, "GAP(%u):", msg_seq_gap(msg));
tipc_printf(buf, "LSTBC(%u):",msg_last_bcast(msg)); tipc_printf(buf, "LSTBC(%u):", msg_last_bcast(msg));
break; break;
case RESET_MSG: case RESET_MSG:
tipc_printf(buf, "RESET:"); tipc_printf(buf, "RESET:");
if (msg_size(msg) != msg_hdr_sz(msg)) if (msg_size(msg) != msg_hdr_sz(msg))
tipc_printf(buf, "BEAR:%s:",msg_data(msg)); tipc_printf(buf, "BEAR:%s:", msg_data(msg));
break; break;
case ACTIVATE_MSG: case ACTIVATE_MSG:
tipc_printf(buf, "ACTIVATE:"); tipc_printf(buf, "ACTIVATE:");
break; break;
default: default:
tipc_printf(buf, "UNKNOWN TYPE:%x",msg_type(msg)); tipc_printf(buf, "UNKNOWN TYPE:%x", msg_type(msg));
} }
tipc_printf(buf, "PLANE(%c):",msg_net_plane(msg)); tipc_printf(buf, "PLANE(%c):", msg_net_plane(msg));
tipc_printf(buf, "SESS(%u):",msg_session(msg)); tipc_printf(buf, "SESS(%u):", msg_session(msg));
break; break;
case CHANGEOVER_PROTOCOL: case CHANGEOVER_PROTOCOL:
tipc_printf(buf, "TUNL:"); tipc_printf(buf, "TUNL:");
...@@ -269,10 +269,10 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str) ...@@ -269,10 +269,10 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str)
break; break;
case ORIGINAL_MSG: case ORIGINAL_MSG:
tipc_printf(buf, "ORIG:"); tipc_printf(buf, "ORIG:");
tipc_printf(buf, "EXP(%u)",msg_msgcnt(msg)); tipc_printf(buf, "EXP(%u)", msg_msgcnt(msg));
break; break;
default: default:
tipc_printf(buf, "UNKNOWN TYPE:%x",msg_type(msg)); tipc_printf(buf, "UNKNOWN TYPE:%x", msg_type(msg));
} }
break; break;
case ROUTE_DISTRIBUTOR: case ROUTE_DISTRIBUTOR:
...@@ -280,26 +280,26 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str) ...@@ -280,26 +280,26 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str)
switch (msg_type(msg)) { switch (msg_type(msg)) {
case EXT_ROUTING_TABLE: case EXT_ROUTING_TABLE:
tipc_printf(buf, "EXT_TBL:"); tipc_printf(buf, "EXT_TBL:");
tipc_printf(buf, "TO:%x:",msg_remote_node(msg)); tipc_printf(buf, "TO:%x:", msg_remote_node(msg));
break; break;
case LOCAL_ROUTING_TABLE: case LOCAL_ROUTING_TABLE:
tipc_printf(buf, "LOCAL_TBL:"); tipc_printf(buf, "LOCAL_TBL:");
tipc_printf(buf, "TO:%x:",msg_remote_node(msg)); tipc_printf(buf, "TO:%x:", msg_remote_node(msg));
break; break;
case SLAVE_ROUTING_TABLE: case SLAVE_ROUTING_TABLE:
tipc_printf(buf, "DP_TBL:"); tipc_printf(buf, "DP_TBL:");
tipc_printf(buf, "TO:%x:",msg_remote_node(msg)); tipc_printf(buf, "TO:%x:", msg_remote_node(msg));
break; break;
case ROUTE_ADDITION: case ROUTE_ADDITION:
tipc_printf(buf, "ADD:"); tipc_printf(buf, "ADD:");
tipc_printf(buf, "TO:%x:",msg_remote_node(msg)); tipc_printf(buf, "TO:%x:", msg_remote_node(msg));
break; break;
case ROUTE_REMOVAL: case ROUTE_REMOVAL:
tipc_printf(buf, "REMOVE:"); tipc_printf(buf, "REMOVE:");
tipc_printf(buf, "TO:%x:",msg_remote_node(msg)); tipc_printf(buf, "TO:%x:", msg_remote_node(msg));
break; break;
default: default:
tipc_printf(buf, "UNKNOWN TYPE:%x",msg_type(msg)); tipc_printf(buf, "UNKNOWN TYPE:%x", msg_type(msg));
} }
break; break;
case LINK_CONFIG: case LINK_CONFIG:
...@@ -312,7 +312,7 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str) ...@@ -312,7 +312,7 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str)
tipc_printf(buf, "DSC_RESP:"); tipc_printf(buf, "DSC_RESP:");
break; break;
default: default:
tipc_printf(buf, "UNKNOWN TYPE:%x:",msg_type(msg)); tipc_printf(buf, "UNKNOWN TYPE:%x:", msg_type(msg));
break; break;
} }
break; break;
...@@ -393,8 +393,8 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str) ...@@ -393,8 +393,8 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str)
} }
if (msg_user(msg) == LINK_CONFIG) { if (msg_user(msg) == LINK_CONFIG) {
u32* raw = (u32*)msg; u32 *raw = (u32 *)msg;
struct tipc_media_addr* orig = (struct tipc_media_addr*)&raw[5]; struct tipc_media_addr *orig = (struct tipc_media_addr *)&raw[5];
tipc_printf(buf, ":REQL(%u):", msg_req_links(msg)); tipc_printf(buf, ":REQL(%u):", msg_req_links(msg));
tipc_printf(buf, ":DDOM(%x):", msg_dest_domain(msg)); tipc_printf(buf, ":DDOM(%x):", msg_dest_domain(msg));
tipc_printf(buf, ":NETID(%u):", msg_bc_netid(msg)); tipc_printf(buf, ":NETID(%u):", msg_bc_netid(msg));
......
...@@ -174,7 +174,7 @@ static inline u32 msg_hdr_sz(struct tipc_msg *m) ...@@ -174,7 +174,7 @@ static inline u32 msg_hdr_sz(struct tipc_msg *m)
return msg_bits(m, 0, 21, 0xf) << 2; return msg_bits(m, 0, 21, 0xf) << 2;
} }
static inline void msg_set_hdr_sz(struct tipc_msg *m,u32 n) static inline void msg_set_hdr_sz(struct tipc_msg *m, u32 n)
{ {
msg_set_bits(m, 0, 21, 0xf, n>>2); msg_set_bits(m, 0, 21, 0xf, n>>2);
} }
...@@ -425,7 +425,7 @@ static inline u32 msg_routed(struct tipc_msg *m) ...@@ -425,7 +425,7 @@ static inline u32 msg_routed(struct tipc_msg *m)
{ {
if (likely(msg_short(m))) if (likely(msg_short(m)))
return 0; return 0;
return(msg_destnode(m) ^ msg_orignode(m)) >> 11; return (msg_destnode(m) ^ msg_orignode(m)) >> 11;
} }
static inline u32 msg_nametype(struct tipc_msg *m) static inline u32 msg_nametype(struct tipc_msg *m)
...@@ -863,7 +863,7 @@ void tipc_msg_init(struct tipc_msg *m, u32 user, u32 type, ...@@ -863,7 +863,7 @@ void tipc_msg_init(struct tipc_msg *m, u32 user, u32 type,
int tipc_msg_calc_data_size(struct iovec const *msg_sect, u32 num_sect); int tipc_msg_calc_data_size(struct iovec const *msg_sect, u32 num_sect);
int tipc_msg_build(struct tipc_msg *hdr, int tipc_msg_build(struct tipc_msg *hdr,
struct iovec const *msg_sect, u32 num_sect, struct iovec const *msg_sect, u32 num_sect,
int max_size, int usrmem, struct sk_buff** buf); int max_size, int usrmem, struct sk_buff **buf);
static inline void msg_set_media_addr(struct tipc_msg *m, struct tipc_media_addr *a) static inline void msg_set_media_addr(struct tipc_msg *m, struct tipc_media_addr *a)
{ {
...@@ -872,7 +872,7 @@ static inline void msg_set_media_addr(struct tipc_msg *m, struct tipc_media_addr ...@@ -872,7 +872,7 @@ static inline void msg_set_media_addr(struct tipc_msg *m, struct tipc_media_addr
static inline void msg_get_media_addr(struct tipc_msg *m, struct tipc_media_addr *a) static inline void msg_get_media_addr(struct tipc_msg *m, struct tipc_media_addr *a)
{ {
memcpy(a, &((int*)m)[5], sizeof(*a)); memcpy(a, &((int *)m)[5], sizeof(*a));
} }
#endif #endif
...@@ -296,8 +296,8 @@ static struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq, ...@@ -296,8 +296,8 @@ static struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq,
sseq = &nseq->sseqs[inspos]; sseq = &nseq->sseqs[inspos];
freesseq = &nseq->sseqs[nseq->first_free]; freesseq = &nseq->sseqs[nseq->first_free];
memmove(sseq + 1, sseq, (freesseq - sseq) * sizeof (*sseq)); memmove(sseq + 1, sseq, (freesseq - sseq) * sizeof(*sseq));
memset(sseq, 0, sizeof (*sseq)); memset(sseq, 0, sizeof(*sseq));
nseq->first_free++; nseq->first_free++;
sseq->lower = lower; sseq->lower = lower;
sseq->upper = upper; sseq->upper = upper;
...@@ -471,7 +471,7 @@ static struct publication *tipc_nameseq_remove_publ(struct name_seq *nseq, u32 i ...@@ -471,7 +471,7 @@ static struct publication *tipc_nameseq_remove_publ(struct name_seq *nseq, u32 i
if (!sseq->zone_list) { if (!sseq->zone_list) {
free = &nseq->sseqs[nseq->first_free--]; free = &nseq->sseqs[nseq->first_free--];
memmove(sseq, sseq + 1, (free - (sseq + 1)) * sizeof (*sseq)); memmove(sseq, sseq + 1, (free - (sseq + 1)) * sizeof(*sseq));
removed_subseq = 1; removed_subseq = 1;
} }
...@@ -507,7 +507,7 @@ static void tipc_nameseq_subscribe(struct name_seq *nseq, struct subscription *s ...@@ -507,7 +507,7 @@ static void tipc_nameseq_subscribe(struct name_seq *nseq, struct subscription *s
while (sseq != &nseq->sseqs[nseq->first_free]) { while (sseq != &nseq->sseqs[nseq->first_free]) {
struct publication *zl = sseq->zone_list; struct publication *zl = sseq->zone_list;
if (zl && tipc_subscr_overlap(s,sseq->lower,sseq->upper)) { if (zl && tipc_subscr_overlap(s, sseq->lower, sseq->upper)) {
struct publication *crs = zl; struct publication *crs = zl;
int must_report = 1; int must_report = 1;
...@@ -798,7 +798,7 @@ void tipc_nametbl_subscribe(struct subscription *s) ...@@ -798,7 +798,7 @@ void tipc_nametbl_subscribe(struct subscription *s)
if (!seq) { if (!seq) {
seq = tipc_nameseq_create(type, &table.types[hash(type)]); seq = tipc_nameseq_create(type, &table.types[hash(type)]);
} }
if (seq){ if (seq) {
spin_lock_bh(&seq->lock); spin_lock_bh(&seq->lock);
tipc_nameseq_subscribe(seq, s); tipc_nameseq_subscribe(seq, s);
spin_unlock_bh(&seq->lock); spin_unlock_bh(&seq->lock);
...@@ -819,7 +819,7 @@ void tipc_nametbl_unsubscribe(struct subscription *s) ...@@ -819,7 +819,7 @@ void tipc_nametbl_unsubscribe(struct subscription *s)
write_lock_bh(&tipc_nametbl_lock); write_lock_bh(&tipc_nametbl_lock);
seq = nametbl_find_seq(s->seq.type); seq = nametbl_find_seq(s->seq.type);
if (seq != NULL){ if (seq != NULL) {
spin_lock_bh(&seq->lock); spin_lock_bh(&seq->lock);
list_del_init(&s->nameseq_list); list_del_init(&s->nameseq_list);
spin_unlock_bh(&seq->lock); spin_unlock_bh(&seq->lock);
...@@ -852,7 +852,7 @@ static void subseq_list(struct sub_seq *sseq, struct print_buf *buf, u32 depth, ...@@ -852,7 +852,7 @@ static void subseq_list(struct sub_seq *sseq, struct print_buf *buf, u32 depth,
} }
do { do {
sprintf (portIdStr, "<%u.%u.%u:%u>", sprintf(portIdStr, "<%u.%u.%u:%u>",
tipc_zone(publ->node), tipc_cluster(publ->node), tipc_zone(publ->node), tipc_cluster(publ->node),
tipc_node(publ->node), publ->ref); tipc_node(publ->node), publ->ref);
tipc_printf(buf, "%-26s ", portIdStr); tipc_printf(buf, "%-26s ", portIdStr);
......
...@@ -334,7 +334,7 @@ static void node_lost_contact(struct tipc_node *n_ptr) ...@@ -334,7 +334,7 @@ static void node_lost_contact(struct tipc_node *n_ptr)
/* Clean up broadcast reception remains */ /* Clean up broadcast reception remains */
n_ptr->bclink.gap_after = n_ptr->bclink.gap_to = 0; n_ptr->bclink.gap_after = n_ptr->bclink.gap_to = 0;
while (n_ptr->bclink.deferred_head) { while (n_ptr->bclink.deferred_head) {
struct sk_buff* buf = n_ptr->bclink.deferred_head; struct sk_buff *buf = n_ptr->bclink.deferred_head;
n_ptr->bclink.deferred_head = buf->next; n_ptr->bclink.deferred_head = buf->next;
buf_discard(buf); buf_discard(buf);
} }
......
...@@ -54,8 +54,8 @@ static DEFINE_SPINLOCK(queue_lock); ...@@ -54,8 +54,8 @@ static DEFINE_SPINLOCK(queue_lock);
static LIST_HEAD(ports); static LIST_HEAD(ports);
static void port_handle_node_down(unsigned long ref); static void port_handle_node_down(unsigned long ref);
static struct sk_buff* port_build_self_abort_msg(struct port *,u32 err); static struct sk_buff *port_build_self_abort_msg(struct port *, u32 err);
static struct sk_buff* port_build_peer_abort_msg(struct port *,u32 err); static struct sk_buff *port_build_peer_abort_msg(struct port *, u32 err);
static void port_timeout(unsigned long ref); static void port_timeout(unsigned long ref);
...@@ -155,7 +155,7 @@ int tipc_multicast(u32 ref, struct tipc_name_seq const *seq, ...@@ -155,7 +155,7 @@ int tipc_multicast(u32 ref, struct tipc_name_seq const *seq,
void tipc_port_recv_mcast(struct sk_buff *buf, struct port_list *dp) void tipc_port_recv_mcast(struct sk_buff *buf, struct port_list *dp)
{ {
struct tipc_msg* msg; struct tipc_msg *msg;
struct port_list dports = {0, NULL, }; struct port_list dports = {0, NULL, };
struct port_list *item = dp; struct port_list *item = dp;
int cnt = 0; int cnt = 0;
...@@ -193,7 +193,7 @@ void tipc_port_recv_mcast(struct sk_buff *buf, struct port_list *dp) ...@@ -193,7 +193,7 @@ void tipc_port_recv_mcast(struct sk_buff *buf, struct port_list *dp)
if ((index == 0) && (cnt != 0)) { if ((index == 0) && (cnt != 0)) {
item = item->next; item = item->next;
} }
msg_set_destport(buf_msg(b),item->ports[index]); msg_set_destport(buf_msg(b), item->ports[index]);
tipc_port_recv_msg(b); tipc_port_recv_msg(b);
} }
} }
...@@ -484,7 +484,7 @@ static void port_timeout(unsigned long ref) ...@@ -484,7 +484,7 @@ static void port_timeout(unsigned long ref)
static void port_handle_node_down(unsigned long ref) static void port_handle_node_down(unsigned long ref)
{ {
struct port *p_ptr = tipc_port_lock(ref); struct port *p_ptr = tipc_port_lock(ref);
struct sk_buff* buf = NULL; struct sk_buff *buf = NULL;
if (!p_ptr) if (!p_ptr)
return; return;
...@@ -620,8 +620,7 @@ static void port_print(struct port *p_ptr, struct print_buf *buf, int full_id) ...@@ -620,8 +620,7 @@ static void port_print(struct port *p_ptr, struct print_buf *buf, int full_id)
tipc_printf(buf, " via {%u,%u}", tipc_printf(buf, " via {%u,%u}",
p_ptr->publ.conn_type, p_ptr->publ.conn_type,
p_ptr->publ.conn_instance); p_ptr->publ.conn_instance);
} } else if (p_ptr->publ.published) {
else if (p_ptr->publ.published) {
tipc_printf(buf, " bound to"); tipc_printf(buf, " bound to");
list_for_each_entry(publ, &p_ptr->publications, pport_list) { list_for_each_entry(publ, &p_ptr->publications, pport_list) {
if (publ->lower == publ->upper) if (publ->lower == publ->upper)
...@@ -1099,7 +1098,7 @@ int tipc_connect2port(u32 ref, struct tipc_portid const *peer) ...@@ -1099,7 +1098,7 @@ int tipc_connect2port(u32 ref, struct tipc_portid const *peer)
p_ptr->publ.connected = 1; p_ptr->publ.connected = 1;
k_start_timer(&p_ptr->timer, p_ptr->probing_interval); k_start_timer(&p_ptr->timer, p_ptr->probing_interval);
tipc_nodesub_subscribe(&p_ptr->subscription,peer->node, tipc_nodesub_subscribe(&p_ptr->subscription, peer->node,
(void *)(unsigned long)ref, (void *)(unsigned long)ref,
(net_ev_handler)port_handle_node_down); (net_ev_handler)port_handle_node_down);
res = 0; res = 0;
......
...@@ -258,7 +258,7 @@ static inline void tipc_port_unlock(struct port *p_ptr) ...@@ -258,7 +258,7 @@ static inline void tipc_port_unlock(struct port *p_ptr)
spin_unlock_bh(p_ptr->publ.lock); spin_unlock_bh(p_ptr->publ.lock);
} }
static inline struct port* tipc_port_deref(u32 ref) static inline struct port *tipc_port_deref(u32 ref)
{ {
return (struct port *)tipc_ref_deref(ref); return (struct port *)tipc_ref_deref(ref);
} }
......
...@@ -178,14 +178,12 @@ u32 tipc_ref_acquire(void *object, spinlock_t **lock) ...@@ -178,14 +178,12 @@ u32 tipc_ref_acquire(void *object, spinlock_t **lock)
next_plus_upper = entry->ref; next_plus_upper = entry->ref;
tipc_ref_table.first_free = next_plus_upper & index_mask; tipc_ref_table.first_free = next_plus_upper & index_mask;
ref = (next_plus_upper & ~index_mask) + index; ref = (next_plus_upper & ~index_mask) + index;
} } else if (tipc_ref_table.init_point < tipc_ref_table.capacity) {
else if (tipc_ref_table.init_point < tipc_ref_table.capacity) {
index = tipc_ref_table.init_point++; index = tipc_ref_table.init_point++;
entry = &(tipc_ref_table.entries[index]); entry = &(tipc_ref_table.entries[index]);
spin_lock_init(&entry->lock); spin_lock_init(&entry->lock);
ref = tipc_ref_table.start_mask + index; ref = tipc_ref_table.start_mask + index;
} } else {
else {
ref = 0; ref = 0;
} }
write_unlock_bh(&ref_table_lock); write_unlock_bh(&ref_table_lock);
......
...@@ -570,14 +570,12 @@ static int send_msg(struct kiocb *iocb, struct socket *sock, ...@@ -570,14 +570,12 @@ static int send_msg(struct kiocb *iocb, struct socket *sock,
dest->addr.name.domain, dest->addr.name.domain,
m->msg_iovlen, m->msg_iovlen,
m->msg_iov); m->msg_iov);
} } else if (dest->addrtype == TIPC_ADDR_ID) {
else if (dest->addrtype == TIPC_ADDR_ID) {
res = tipc_send2port(tport->ref, res = tipc_send2port(tport->ref,
&dest->addr.id, &dest->addr.id,
m->msg_iovlen, m->msg_iovlen,
m->msg_iov); m->msg_iov);
} } else if (dest->addrtype == TIPC_ADDR_MCAST) {
else if (dest->addrtype == TIPC_ADDR_MCAST) {
if (needs_conn) { if (needs_conn) {
res = -EOPNOTSUPP; res = -EOPNOTSUPP;
break; break;
......
...@@ -538,7 +538,7 @@ int tipc_subscr_start(void) ...@@ -538,7 +538,7 @@ int tipc_subscr_start(void)
struct tipc_name_seq seq = {TIPC_TOP_SRV, TIPC_TOP_SRV, TIPC_TOP_SRV}; struct tipc_name_seq seq = {TIPC_TOP_SRV, TIPC_TOP_SRV, TIPC_TOP_SRV};
int res; int res;
memset(&topsrv, 0, sizeof (topsrv)); memset(&topsrv, 0, sizeof(topsrv));
spin_lock_init(&topsrv.lock); spin_lock_init(&topsrv.lock);
INIT_LIST_HEAD(&topsrv.subscriber_list); INIT_LIST_HEAD(&topsrv.subscriber_list);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment