Skip to content

L
linux
Commit 0f817a5e authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller
Browse files
Options

mISDN: Delete unnecessary checks before the macro call “dev_kfree_skb” 

The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d3ee8ec7
Hide whitespace changes
Inline Side-by-side
Showing with 20 additions and 40 deletions
drivers/isdn/hardware/mISDN/avmfritz.c
View file @ 0f817a5e
...@@ -509,8 +509,7 @@ HDLC_irq_xpr(struct bchannel *bch) ...@@ -509,8 +509,7 @@ HDLC_irq_xpr(struct bchannel *bch)
if (bch->tx_skb && bch->tx_idx < bch->tx_skb->len) { if (bch->tx_skb && bch->tx_idx < bch->tx_skb->len) {
hdlc_fill_fifo(bch); hdlc_fill_fifo(bch);
} else { } else {
if (bch->tx_skb) dev_kfree_skb(bch->tx_skb);
dev_kfree_skb(bch->tx_skb);
if (get_next_bframe(bch)) { if (get_next_bframe(bch)) {
hdlc_fill_fifo(bch); hdlc_fill_fifo(bch);
test_and_clear_bit(FLG_TX_EMPTY, &bch->Flags); test_and_clear_bit(FLG_TX_EMPTY, &bch->Flags);
......
drivers/isdn/hardware/mISDN/hfcpci.c
View file @ 0f817a5e
...@@ -1119,8 +1119,7 @@ tx_birq(struct bchannel *bch) ...@@ -1119,8 +1119,7 @@ tx_birq(struct bchannel *bch)
if (bch->tx_skb && bch->tx_idx < bch->tx_skb->len) if (bch->tx_skb && bch->tx_idx < bch->tx_skb->len)
hfcpci_fill_fifo(bch); hfcpci_fill_fifo(bch);
else { else {
if (bch->tx_skb) dev_kfree_skb(bch->tx_skb);
dev_kfree_skb(bch->tx_skb);
if (get_next_bframe(bch)) if (get_next_bframe(bch))
hfcpci_fill_fifo(bch); hfcpci_fill_fifo(bch);
} }
...@@ -1132,8 +1131,7 @@ tx_dirq(struct dchannel *dch) ...@@ -1132,8 +1131,7 @@ tx_dirq(struct dchannel *dch)
if (dch->tx_skb && dch->tx_idx < dch->tx_skb->len) if (dch->tx_skb && dch->tx_idx < dch->tx_skb->len)
hfcpci_fill_dfifo(dch->hw); hfcpci_fill_dfifo(dch->hw);
else { else {
if (dch->tx_skb) dev_kfree_skb(dch->tx_skb);
dev_kfree_skb(dch->tx_skb);
if (get_next_dframe(dch)) if (get_next_dframe(dch))
hfcpci_fill_dfifo(dch->hw); hfcpci_fill_dfifo(dch->hw);
} }
......
drivers/isdn/hardware/mISDN/mISDNipac.c
View file @ 0f817a5e
...@@ -190,8 +190,7 @@ isac_rme_irq(struct isac_hw *isac) ...@@ -190,8 +190,7 @@ isac_rme_irq(struct isac_hw *isac)
#endif #endif
} }
WriteISAC(isac, ISAC_CMDR, 0x80); WriteISAC(isac, ISAC_CMDR, 0x80);
if (isac->dch.rx_skb) dev_kfree_skb(isac->dch.rx_skb);
dev_kfree_skb(isac->dch.rx_skb);
isac->dch.rx_skb = NULL; isac->dch.rx_skb = NULL;
} else { } else {
count = ReadISAC(isac, ISAC_RBCL) & 0x1f; count = ReadISAC(isac, ISAC_RBCL) & 0x1f;
...@@ -210,8 +209,7 @@ isac_xpr_irq(struct isac_hw *isac) ...@@ -210,8 +209,7 @@ isac_xpr_irq(struct isac_hw *isac)
if (isac->dch.tx_skb && isac->dch.tx_idx < isac->dch.tx_skb->len) { if (isac->dch.tx_skb && isac->dch.tx_idx < isac->dch.tx_skb->len) {
isac_fill_fifo(isac); isac_fill_fifo(isac);
} else { } else {
if (isac->dch.tx_skb) dev_kfree_skb(isac->dch.tx_skb);
dev_kfree_skb(isac->dch.tx_skb);
if (get_next_dframe(&isac->dch)) if (get_next_dframe(&isac->dch))
isac_fill_fifo(isac); isac_fill_fifo(isac);
} }
...@@ -464,8 +462,7 @@ isacsx_rme_irq(struct isac_hw *isac) ...@@ -464,8 +462,7 @@ isacsx_rme_irq(struct isac_hw *isac)
isac->dch.err_crc++; isac->dch.err_crc++;
#endif #endif
WriteISAC(isac, ISACX_CMDRD, ISACX_CMDRD_RMC); WriteISAC(isac, ISACX_CMDRD, ISACX_CMDRD_RMC);
if (isac->dch.rx_skb) dev_kfree_skb(isac->dch.rx_skb);
dev_kfree_skb(isac->dch.rx_skb);
isac->dch.rx_skb = NULL; isac->dch.rx_skb = NULL;
} else { } else {
count = ReadISAC(isac, ISACX_RBCLD) & 0x1f; count = ReadISAC(isac, ISACX_RBCLD) & 0x1f;
...@@ -1012,8 +1009,7 @@ hscx_xpr(struct hscx_hw *hx) ...@@ -1012,8 +1009,7 @@ hscx_xpr(struct hscx_hw *hx)
if (hx->bch.tx_skb && hx->bch.tx_idx < hx->bch.tx_skb->len) { if (hx->bch.tx_skb && hx->bch.tx_idx < hx->bch.tx_skb->len) {
hscx_fill_fifo(hx); hscx_fill_fifo(hx);
} else { } else {
if (hx->bch.tx_skb) dev_kfree_skb(hx->bch.tx_skb);
dev_kfree_skb(hx->bch.tx_skb);
if (get_next_bframe(&hx->bch)) { if (get_next_bframe(&hx->bch)) {
hscx_fill_fifo(hx); hscx_fill_fifo(hx);
test_and_clear_bit(FLG_TX_EMPTY, &hx->bch.Flags); test_and_clear_bit(FLG_TX_EMPTY, &hx->bch.Flags);
......
drivers/isdn/hardware/mISDN/mISDNisar.c
View file @ 0f817a5e
...@@ -690,8 +690,7 @@ send_next(struct isar_ch *ch) ...@@ -690,8 +690,7 @@ send_next(struct isar_ch *ch)
} }
} }
} }
if (ch->bch.tx_skb) dev_kfree_skb(ch->bch.tx_skb);
dev_kfree_skb(ch->bch.tx_skb);
if (get_next_bframe(&ch->bch)) { if (get_next_bframe(&ch->bch)) {
isar_fill_fifo(ch); isar_fill_fifo(ch);
test_and_clear_bit(FLG_TX_EMPTY, &ch->bch.Flags); test_and_clear_bit(FLG_TX_EMPTY, &ch->bch.Flags);
......
drivers/isdn/hardware/mISDN/netjet.c
View file @ 0f817a5e
...@@ -605,8 +605,7 @@ bc_next_frame(struct tiger_ch *bc) ...@@ -605,8 +605,7 @@ bc_next_frame(struct tiger_ch *bc)
if (bc->bch.tx_skb && bc->bch.tx_idx < bc->bch.tx_skb->len) { if (bc->bch.tx_skb && bc->bch.tx_idx < bc->bch.tx_skb->len) {
fill_dma(bc); fill_dma(bc);
} else { } else {
if (bc->bch.tx_skb) dev_kfree_skb(bc->bch.tx_skb);
dev_kfree_skb(bc->bch.tx_skb);
if (get_next_bframe(&bc->bch)) { if (get_next_bframe(&bc->bch)) {
fill_dma(bc); fill_dma(bc);
test_and_clear_bit(FLG_TX_EMPTY, &bc->bch.Flags); test_and_clear_bit(FLG_TX_EMPTY, &bc->bch.Flags);
......
drivers/isdn/hardware/mISDN/w6692.c
View file @ 0f817a5e
...@@ -356,8 +356,7 @@ handle_rxD(struct w6692_hw *card) { ...@@ -356,8 +356,7 @@ handle_rxD(struct w6692_hw *card) {
card->dch.err_rx++; card->dch.err_rx++;
#endif #endif
} }
if (card->dch.rx_skb) dev_kfree_skb(card->dch.rx_skb);
dev_kfree_skb(card->dch.rx_skb);
card->dch.rx_skb = NULL; card->dch.rx_skb = NULL;
WriteW6692(card, W_D_CMDR, W_D_CMDR_RACK | W_D_CMDR_RRST); WriteW6692(card, W_D_CMDR, W_D_CMDR_RACK | W_D_CMDR_RRST);
} else { } else {
...@@ -376,8 +375,7 @@ handle_txD(struct w6692_hw *card) { ...@@ -376,8 +375,7 @@ handle_txD(struct w6692_hw *card) {
if (card->dch.tx_skb && card->dch.tx_idx < card->dch.tx_skb->len) { if (card->dch.tx_skb && card->dch.tx_idx < card->dch.tx_skb->len) {
W6692_fill_Dfifo(card); W6692_fill_Dfifo(card);
} else { } else {
if (card->dch.tx_skb) dev_kfree_skb(card->dch.tx_skb);
dev_kfree_skb(card->dch.tx_skb);
if (get_next_dframe(&card->dch)) if (get_next_dframe(&card->dch))
W6692_fill_Dfifo(card); W6692_fill_Dfifo(card);
} }
...@@ -636,8 +634,7 @@ send_next(struct w6692_ch *wch) ...@@ -636,8 +634,7 @@ send_next(struct w6692_ch *wch)
if (wch->bch.tx_skb && wch->bch.tx_idx < wch->bch.tx_skb->len) { if (wch->bch.tx_skb && wch->bch.tx_idx < wch->bch.tx_skb->len) {
W6692_fill_Bfifo(wch); W6692_fill_Bfifo(wch);
} else { } else {
if (wch->bch.tx_skb) dev_kfree_skb(wch->bch.tx_skb);
dev_kfree_skb(wch->bch.tx_skb);
if (get_next_bframe(&wch->bch)) { if (get_next_bframe(&wch->bch)) {
W6692_fill_Bfifo(wch); W6692_fill_Bfifo(wch);
test_and_clear_bit(FLG_TX_EMPTY, &wch->bch.Flags); test_and_clear_bit(FLG_TX_EMPTY, &wch->bch.Flags);
......
drivers/isdn/mISDN/l1oip_core.c
View file @ 0f817a5e
...@@ -1254,8 +1254,7 @@ release_card(struct l1oip *hc) ...@@ -1254,8 +1254,7 @@ release_card(struct l1oip *hc)
mISDN_freebchannel(hc->chan[ch].bch); mISDN_freebchannel(hc->chan[ch].bch);
kfree(hc->chan[ch].bch); kfree(hc->chan[ch].bch);
#ifdef REORDER_DEBUG #ifdef REORDER_DEBUG
if (hc->chan[ch].disorder_skb) dev_kfree_skb(hc->chan[ch].disorder_skb);
dev_kfree_skb(hc->chan[ch].disorder_skb);
#endif #endif
} }
} }
......
drivers/isdn/mISDN/layer2.c
View file @ 0f817a5e
...@@ -900,8 +900,7 @@ l2_disconnect(struct FsmInst *fi, int event, void *arg) ...@@ -900,8 +900,7 @@ l2_disconnect(struct FsmInst *fi, int event, void *arg)
send_uframe(l2, NULL, DISC | 0x10, CMD); send_uframe(l2, NULL, DISC | 0x10, CMD);
mISDN_FsmDelTimer(&l2->t203, 1); mISDN_FsmDelTimer(&l2->t203, 1);
restart_t200(l2, 2); restart_t200(l2, 2);
if (skb) dev_kfree_skb(skb);
dev_kfree_skb(skb);
} }
static void static void
...@@ -1722,8 +1721,7 @@ l2_set_own_busy(struct FsmInst *fi, int event, void *arg) ...@@ -1722,8 +1721,7 @@ l2_set_own_busy(struct FsmInst *fi, int event, void *arg)
enquiry_cr(l2, RNR, RSP, 0); enquiry_cr(l2, RNR, RSP, 0);
test_and_clear_bit(FLG_ACK_PEND, &l2->flag); test_and_clear_bit(FLG_ACK_PEND, &l2->flag);
} }
if (skb) dev_kfree_skb(skb);
dev_kfree_skb(skb);
} }
static void static void
...@@ -1736,8 +1734,7 @@ l2_clear_own_busy(struct FsmInst *fi, int event, void *arg) ...@@ -1736,8 +1734,7 @@ l2_clear_own_busy(struct FsmInst *fi, int event, void *arg)
enquiry_cr(l2, RR, RSP, 0); enquiry_cr(l2, RR, RSP, 0);
test_and_clear_bit(FLG_ACK_PEND, &l2->flag); test_and_clear_bit(FLG_ACK_PEND, &l2->flag);
} }
if (skb) dev_kfree_skb(skb);
dev_kfree_skb(skb);
} }
static void static void
......
drivers/isdn/mISDN/stack.c
View file @ 0f817a5e
...@@ -75,8 +75,7 @@ send_socklist(struct mISDN_sock_list *sl, struct sk_buff *skb) ...@@ -75,8 +75,7 @@ send_socklist(struct mISDN_sock_list *sl, struct sk_buff *skb)
cskb = NULL; cskb = NULL;
} }
read_unlock(&sl->lock); read_unlock(&sl->lock);
if (cskb) dev_kfree_skb(cskb);
dev_kfree_skb(cskb);
} }
static void static void
...@@ -134,8 +133,7 @@ send_layer2(struct mISDNstack *st, struct sk_buff *skb) ...@@ -134,8 +133,7 @@ send_layer2(struct mISDNstack *st, struct sk_buff *skb)
} }
out: out:
mutex_unlock(&st->lmutex); mutex_unlock(&st->lmutex);
if (skb) dev_kfree_skb(skb);
dev_kfree_skb(skb);
} }
static inline int static inline int
......
drivers/isdn/mISDN/tei.c
View file @ 0f817a5e
...@@ -1328,10 +1328,8 @@ mgr_bcast(struct mISDNchannel *ch, struct sk_buff *skb) ...@@ -1328,10 +1328,8 @@ mgr_bcast(struct mISDNchannel *ch, struct sk_buff *skb)
} }
out: out:
read_unlock_irqrestore(&mgr->lock, flags); read_unlock_irqrestore(&mgr->lock, flags);
if (cskb) dev_kfree_skb(cskb);
dev_kfree_skb(cskb); dev_kfree_skb(skb);
if (skb)
dev_kfree_skb(skb);
return 0; return 0;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7