Commit 10ad5278 authored by Rahul Ruikar's avatar Rahul Ruikar Committed by Linus Torvalds

drivers/misc/phantom.c: add missing warning messages in phantom_probe()

phantom_probe() can fail in many places.  Add missing warning messages in
pci_enable_device() and pci_request_regions().
Signed-off-by: default avatarRahul Ruikar <rahul.ruikar@gmail.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ca1cab37
...@@ -343,8 +343,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev, ...@@ -343,8 +343,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
int retval; int retval;
retval = pci_enable_device(pdev); retval = pci_enable_device(pdev);
if (retval) if (retval) {
dev_err(&pdev->dev, "pci_enable_device failed!\n");
goto err; goto err;
}
minor = phantom_get_free(); minor = phantom_get_free();
if (minor == PHANTOM_MAX_MINORS) { if (minor == PHANTOM_MAX_MINORS) {
...@@ -356,8 +358,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev, ...@@ -356,8 +358,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
phantom_devices[minor] = 1; phantom_devices[minor] = 1;
retval = pci_request_regions(pdev, "phantom"); retval = pci_request_regions(pdev, "phantom");
if (retval) if (retval) {
dev_err(&pdev->dev, "pci_request_regions failed!\n");
goto err_null; goto err_null;
}
retval = -ENOMEM; retval = -ENOMEM;
pht = kzalloc(sizeof(*pht), GFP_KERNEL); pht = kzalloc(sizeof(*pht), GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment