Commit 10f0577a authored by Dan Carpenter's avatar Dan Carpenter Committed by Felipe Balbi

usb: phy: msm: change devm_ioremap() to devm_ioremap_resource()

There are several issues here:
1) platform_get_resource() can return NULL and that wasn't handled.
2) We should request the memory before we remap it, and
   devm_ioremap_resource() does that.
3) devm_ioremap() returns a NULL but we were checking for IS_ERR().

Fixes: 6b99c68e ('usb: phy: msm: Migrate to Managed Device Resource allocation')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent c5ab571f
...@@ -1586,7 +1586,7 @@ static int msm_otg_probe(struct platform_device *pdev) ...@@ -1586,7 +1586,7 @@ static int msm_otg_probe(struct platform_device *pdev)
np ? "alt_core" : "usb_hs_core_clk"); np ? "alt_core" : "usb_hs_core_clk");
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
motg->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); motg->regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(motg->regs)) if (IS_ERR(motg->regs))
return PTR_ERR(motg->regs); return PTR_ERR(motg->regs);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment