Commit 11fb09bf authored by Harvey Harrison's avatar Harvey Harrison Committed by Linus Torvalds

epca.c: static functions and integer as NULL pointer fixes

drivers/char/epca.c:926:28: warning: Using plain integer as NULL pointer
drivers/char/epca.c:1841:2: warning: Using plain integer as NULL pointer

Forward declarations were already marked static, mark the definitions too.
drivers/char/epca.c:2493:6: warning: symbol 'digi_send_break' was not declared. Should it be static?
drivers/char/epca.c:2881:12: warning: symbol 'init_PCI' was not declared. Should it be static?

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1a4e2351
...@@ -923,7 +923,8 @@ static int pc_open(struct tty_struct *tty, struct file * filp) ...@@ -923,7 +923,8 @@ static int pc_open(struct tty_struct *tty, struct file * filp)
return(-ENODEV); return(-ENODEV);
} }
if ((bc = ch->brdchan) == 0) { bc = ch->brdchan;
if (bc == NULL) {
tty->driver_data = NULL; tty->driver_data = NULL;
return -ENODEV; return -ENODEV;
} }
...@@ -1838,7 +1839,7 @@ static void epcaparam(struct tty_struct *tty, struct channel *ch) ...@@ -1838,7 +1839,7 @@ static void epcaparam(struct tty_struct *tty, struct channel *ch)
unsigned mval, hflow, cflag, iflag; unsigned mval, hflow, cflag, iflag;
bc = ch->brdchan; bc = ch->brdchan;
epcaassert(bc !=0, "bc out of range"); epcaassert(bc != NULL, "bc out of range");
assertgwinon(ch); assertgwinon(ch);
ts = tty->termios; ts = tty->termios;
...@@ -2477,7 +2478,7 @@ static void pc_unthrottle(struct tty_struct *tty) ...@@ -2477,7 +2478,7 @@ static void pc_unthrottle(struct tty_struct *tty)
} }
} }
void digi_send_break(struct channel *ch, int msec) static void digi_send_break(struct channel *ch, int msec)
{ {
unsigned long flags; unsigned long flags;
...@@ -2865,7 +2866,7 @@ static struct pci_device_id epca_pci_tbl[] = { ...@@ -2865,7 +2866,7 @@ static struct pci_device_id epca_pci_tbl[] = {
MODULE_DEVICE_TABLE(pci, epca_pci_tbl); MODULE_DEVICE_TABLE(pci, epca_pci_tbl);
int __init init_PCI (void) static int __init init_PCI(void)
{ {
memset (&epca_driver, 0, sizeof (epca_driver)); memset (&epca_driver, 0, sizeof (epca_driver));
epca_driver.name = "epca"; epca_driver.name = "epca";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment