Commit 12acd136 authored by Rafał Miłecki's avatar Rafał Miłecki Committed by David S. Miller

net: bgmac: enable master mode for BCM54210E and B50212E PHYs

There are 4 very similar PHYs:
0x600d84a1: BCM54210E (rev B0)
0x600d84a2: BCM54210E (rev B1)
0x600d84a5: B50212E (rev B0)
0x600d84a6: B50212E (rev B1)
that need setting master mode manually. It's because they run in slave
mode by default with Automatic Slave/Master configuration disabled which
can lead to unreliable connection with massive ping loss.

So far it was reported for a board with BCM47189 SoC and B50212E B1 PHY
connected to the bgmac supported ethernet device. Telling PHY driver to
setup PHY properly solves this issue.
Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2355a654
...@@ -184,13 +184,19 @@ static int bgmac_probe(struct bcma_device *core) ...@@ -184,13 +184,19 @@ static int bgmac_probe(struct bcma_device *core)
if (!bgmac_is_bcm4707_family(core) && if (!bgmac_is_bcm4707_family(core) &&
!(ci->id == BCMA_CHIP_ID_BCM53573 && core->core_unit == 1)) { !(ci->id == BCMA_CHIP_ID_BCM53573 && core->core_unit == 1)) {
struct phy_device *phydev;
mii_bus = bcma_mdio_mii_register(bgmac); mii_bus = bcma_mdio_mii_register(bgmac);
if (IS_ERR(mii_bus)) { if (IS_ERR(mii_bus)) {
err = PTR_ERR(mii_bus); err = PTR_ERR(mii_bus);
goto err; goto err;
} }
bgmac->mii_bus = mii_bus; bgmac->mii_bus = mii_bus;
phydev = mdiobus_get_phy(bgmac->mii_bus, bgmac->phyaddr);
if (ci->id == BCMA_CHIP_ID_BCM53573 && phydev &&
(phydev->drv->phy_id & phydev->drv->phy_id_mask) == PHY_ID_BCM54210E)
phydev->dev_flags |= PHY_BRCM_EN_MASTER_MODE;
} }
if (core->bus->hosttype == BCMA_HOSTTYPE_PCI) { if (core->bus->hosttype == BCMA_HOSTTYPE_PCI) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment