Commit 12adef5b authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Chanwoo Choi

extcon: max14577: Fix probe failure on successful work queue

In probe the driver queued delayed work for cable detection and
returned the result of queue_delayed_work() call. However the return
value of queue_delayed_work() does not indicate an error and in normal
condition it returns true which means successful work queue.
This effectively resulted in probe failure:
[    2.088204] max14577-muic: probe of max77836-muic failed with error 1
Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: <stable@vger.kernel.org>
Fixes: 962e56bf ("extcon: max14577: Add extcon-max14577 driver...")
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent a55d952a
...@@ -782,13 +782,8 @@ static int max14577_muic_probe(struct platform_device *pdev) ...@@ -782,13 +782,8 @@ static int max14577_muic_probe(struct platform_device *pdev)
* driver should notify cable state to upper layer. * driver should notify cable state to upper layer.
*/ */
INIT_DELAYED_WORK(&info->wq_detcable, max14577_muic_detect_cable_wq); INIT_DELAYED_WORK(&info->wq_detcable, max14577_muic_detect_cable_wq);
ret = queue_delayed_work(system_power_efficient_wq, &info->wq_detcable, queue_delayed_work(system_power_efficient_wq, &info->wq_detcable,
delay_jiffies); delay_jiffies);
if (ret < 0) {
dev_err(&pdev->dev,
"failed to schedule delayed work for cable detect\n");
goto err_extcon;
}
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment