Commit 12dfd080 authored by Bryan Schumaker's avatar Bryan Schumaker Committed by Trond Myklebust

NFS: return -ENOKEY when the upcall fails to map the name

This allows the normal error-paths to handle the error, rather than
making a special call to complete_request_key() just for this instance.
Signed-off-by: default avatarBryan Schumaker <bjschuma@netapp.com>
Tested-by: default avatarWilliam Dauchy <wdauchy@gmail.com>
Cc: stable@vger.kernel.org [>= 3.4]
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent c5066945
...@@ -760,9 +760,8 @@ idmap_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) ...@@ -760,9 +760,8 @@ idmap_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
} }
if (!(im.im_status & IDMAP_STATUS_SUCCESS)) { if (!(im.im_status & IDMAP_STATUS_SUCCESS)) {
ret = mlen; ret = -ENOKEY;
complete_request_key(cons, -ENOKEY); goto out;
goto out_incomplete;
} }
namelen_in = strnlen(im.im_name, IDMAP_NAMESZ); namelen_in = strnlen(im.im_name, IDMAP_NAMESZ);
...@@ -779,7 +778,6 @@ idmap_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) ...@@ -779,7 +778,6 @@ idmap_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
out: out:
complete_request_key(cons, ret); complete_request_key(cons, ret);
out_incomplete:
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment