Commit 132dfc78 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Chris Wilson

drm/i915: Drop the IRQ-off asserts

The lockdep_assert_irqs_disabled() check is needless. The previous
lockdep_assert_held() check ensures that the lock is acquired and while
the lock is acquired lockdep also prints a warning if the interrupts are
not disabled if they have to be.
These IRQ-off asserts trigger on PREEMPT_RT because the locks become
sleeping locks and do not really disable interrupts.

Remove lockdep_assert_irqs_disabled().
Reported-by: default avatarClark Williams <williams@redhat.com>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20190926105644.16703-3-bigeasy@linutronix.de
parent 7d5255e0
...@@ -120,7 +120,6 @@ __dma_fence_signal__notify(struct dma_fence *fence, ...@@ -120,7 +120,6 @@ __dma_fence_signal__notify(struct dma_fence *fence,
struct dma_fence_cb *cur, *tmp; struct dma_fence_cb *cur, *tmp;
lockdep_assert_held(fence->lock); lockdep_assert_held(fence->lock);
lockdep_assert_irqs_disabled();
list_for_each_entry_safe(cur, tmp, list, node) { list_for_each_entry_safe(cur, tmp, list, node) {
INIT_LIST_HEAD(&cur->node); INIT_LIST_HEAD(&cur->node);
...@@ -275,7 +274,6 @@ void intel_engine_fini_breadcrumbs(struct intel_engine_cs *engine) ...@@ -275,7 +274,6 @@ void intel_engine_fini_breadcrumbs(struct intel_engine_cs *engine)
bool i915_request_enable_breadcrumb(struct i915_request *rq) bool i915_request_enable_breadcrumb(struct i915_request *rq)
{ {
lockdep_assert_held(&rq->lock); lockdep_assert_held(&rq->lock);
lockdep_assert_irqs_disabled();
if (test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags)) { if (test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags)) {
struct intel_breadcrumbs *b = &rq->engine->breadcrumbs; struct intel_breadcrumbs *b = &rq->engine->breadcrumbs;
...@@ -325,7 +323,6 @@ void i915_request_cancel_breadcrumb(struct i915_request *rq) ...@@ -325,7 +323,6 @@ void i915_request_cancel_breadcrumb(struct i915_request *rq)
struct intel_breadcrumbs *b = &rq->engine->breadcrumbs; struct intel_breadcrumbs *b = &rq->engine->breadcrumbs;
lockdep_assert_held(&rq->lock); lockdep_assert_held(&rq->lock);
lockdep_assert_irqs_disabled();
/* /*
* We must wait for b->irq_lock so that we know the interrupt handler * We must wait for b->irq_lock so that we know the interrupt handler
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment