Commit 1362ae43 authored by Andrea Parri's avatar Andrea Parri Committed by Ingo Molnar

locking/spinlocks: Clean up comment and #ifndef for {,queued_}spin_is_locked()

Removes "#ifndef queued_spin_is_locked" from the generic code: this is
unused and it's reasonable to conclude that it will continue to be unused.

Also removes the comment about spin_is_locked() from mutex_is_locked():
the comment remains valid but not particularly useful.
Suggested-by: default avatarWill Deacon <will.deacon@arm.com>
Signed-off-by: default avatarAndrea Parri <andrea.parri@amarulasolutions.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: default avatarWill Deacon <will.deacon@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: akiyks@gmail.com
Cc: boqun.feng@gmail.com
Cc: dhowells@redhat.com
Cc: j.alglave@ucl.ac.uk
Cc: linux-arch@vger.kernel.org
Cc: luc.maranget@inria.fr
Cc: npiggin@gmail.com
Cc: parri.andrea@gmail.com
Cc: stern@rowland.harvard.edu
Link: http://lkml.kernel.org/r/1526338889-7003-3-git-send-email-paulmck@linux.vnet.ibm.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent c6f5d02b
...@@ -26,7 +26,6 @@ ...@@ -26,7 +26,6 @@
* @lock: Pointer to queued spinlock structure * @lock: Pointer to queued spinlock structure
* Return: 1 if it is locked, 0 otherwise * Return: 1 if it is locked, 0 otherwise
*/ */
#ifndef queued_spin_is_locked
static __always_inline int queued_spin_is_locked(struct qspinlock *lock) static __always_inline int queued_spin_is_locked(struct qspinlock *lock)
{ {
/* /*
...@@ -35,7 +34,6 @@ static __always_inline int queued_spin_is_locked(struct qspinlock *lock) ...@@ -35,7 +34,6 @@ static __always_inline int queued_spin_is_locked(struct qspinlock *lock)
*/ */
return atomic_read(&lock->val); return atomic_read(&lock->val);
} }
#endif
/** /**
* queued_spin_value_unlocked - is the spinlock structure unlocked? * queued_spin_value_unlocked - is the spinlock structure unlocked?
......
...@@ -146,9 +146,6 @@ extern void __mutex_init(struct mutex *lock, const char *name, ...@@ -146,9 +146,6 @@ extern void __mutex_init(struct mutex *lock, const char *name,
*/ */
static inline bool mutex_is_locked(struct mutex *lock) static inline bool mutex_is_locked(struct mutex *lock)
{ {
/*
* XXX think about spin_is_locked
*/
return __mutex_owner(lock) != NULL; return __mutex_owner(lock) != NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment