Commit 150d7158 authored by Thomas Gleixner's avatar Thomas Gleixner

futex: Split futex_mm_release() for exit/exec

To allow separate handling of the futex exit state in the futex exit code
for exit and exec, split futex_mm_release() into two functions and invoke
them from the corresponding exit/exec_mm_release() callsites.

Preparatory only, no functional change.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarIngo Molnar <mingo@kernel.org>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20191106224556.332094221@linutronix.de
parent 4610ba7a
...@@ -93,14 +93,16 @@ static inline void futex_exit_done(struct task_struct *tsk) ...@@ -93,14 +93,16 @@ static inline void futex_exit_done(struct task_struct *tsk)
tsk->futex_state = FUTEX_STATE_DEAD; tsk->futex_state = FUTEX_STATE_DEAD;
} }
void futex_mm_release(struct task_struct *tsk); void futex_exit_release(struct task_struct *tsk);
void futex_exec_release(struct task_struct *tsk);
long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout, long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
u32 __user *uaddr2, u32 val2, u32 val3); u32 __user *uaddr2, u32 val2, u32 val3);
#else #else
static inline void futex_init_task(struct task_struct *tsk) { } static inline void futex_init_task(struct task_struct *tsk) { }
static inline void futex_mm_release(struct task_struct *tsk) { }
static inline void futex_exit_done(struct task_struct *tsk) { } static inline void futex_exit_done(struct task_struct *tsk) { }
static inline void futex_exit_release(struct task_struct *tsk) { }
static inline void futex_exec_release(struct task_struct *tsk) { }
static inline long do_futex(u32 __user *uaddr, int op, u32 val, static inline long do_futex(u32 __user *uaddr, int op, u32 val,
ktime_t *timeout, u32 __user *uaddr2, ktime_t *timeout, u32 __user *uaddr2,
u32 val2, u32 val3) u32 val2, u32 val3)
......
...@@ -1285,9 +1285,6 @@ static int wait_for_vfork_done(struct task_struct *child, ...@@ -1285,9 +1285,6 @@ static int wait_for_vfork_done(struct task_struct *child,
*/ */
static void mm_release(struct task_struct *tsk, struct mm_struct *mm) static void mm_release(struct task_struct *tsk, struct mm_struct *mm)
{ {
/* Get rid of any futexes when releasing the mm */
futex_mm_release(tsk);
uprobe_free_utask(tsk); uprobe_free_utask(tsk);
/* Get rid of any cached register state */ /* Get rid of any cached register state */
...@@ -1322,11 +1319,13 @@ static void mm_release(struct task_struct *tsk, struct mm_struct *mm) ...@@ -1322,11 +1319,13 @@ static void mm_release(struct task_struct *tsk, struct mm_struct *mm)
void exit_mm_release(struct task_struct *tsk, struct mm_struct *mm) void exit_mm_release(struct task_struct *tsk, struct mm_struct *mm)
{ {
futex_exit_release(tsk);
mm_release(tsk, mm); mm_release(tsk, mm);
} }
void exec_mm_release(struct task_struct *tsk, struct mm_struct *mm) void exec_mm_release(struct task_struct *tsk, struct mm_struct *mm)
{ {
futex_exec_release(tsk);
mm_release(tsk, mm); mm_release(tsk, mm);
} }
......
...@@ -3661,7 +3661,7 @@ static void exit_robust_list(struct task_struct *curr) ...@@ -3661,7 +3661,7 @@ static void exit_robust_list(struct task_struct *curr)
} }
} }
void futex_mm_release(struct task_struct *tsk) void futex_exec_release(struct task_struct *tsk)
{ {
if (unlikely(tsk->robust_list)) { if (unlikely(tsk->robust_list)) {
exit_robust_list(tsk); exit_robust_list(tsk);
...@@ -3679,6 +3679,11 @@ void futex_mm_release(struct task_struct *tsk) ...@@ -3679,6 +3679,11 @@ void futex_mm_release(struct task_struct *tsk)
exit_pi_state_list(tsk); exit_pi_state_list(tsk);
} }
void futex_exit_release(struct task_struct *tsk)
{
futex_exec_release(tsk);
}
long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout, long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
u32 __user *uaddr2, u32 val2, u32 val3) u32 __user *uaddr2, u32 val2, u32 val3)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment