Commit 151ed9d7 authored by Parav Pandit's avatar Parav Pandit Committed by Jason Gunthorpe

IB/core: Refactor to avoid unnecessary check on GID lookup miss

Currently on every gid entry comparison miss found variable is checked;
which is not needed as those two comparison fail already indicate that
GID is not found yet.
So refactor to avoid such check and copy the GID index when found.
Signed-off-by: default avatarParav Pandit <parav@mellanox.com>
Reviewed-by: default avatarDaniel Jurgens <danielj@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent b0dd0d33
...@@ -573,27 +573,24 @@ static int ib_cache_gid_find_by_filter(struct ib_device *ib_dev, ...@@ -573,27 +573,24 @@ static int ib_cache_gid_find_by_filter(struct ib_device *ib_dev,
struct ib_gid_attr attr; struct ib_gid_attr attr;
if (table->data_vec[i].props & GID_TABLE_ENTRY_INVALID) if (table->data_vec[i].props & GID_TABLE_ENTRY_INVALID)
goto next; continue;
if (memcmp(gid, &table->data_vec[i].gid, sizeof(*gid))) if (memcmp(gid, &table->data_vec[i].gid, sizeof(*gid)))
goto next; continue;
memcpy(&attr, &table->data_vec[i].attr, sizeof(attr)); memcpy(&attr, &table->data_vec[i].attr, sizeof(attr));
if (filter(gid, &attr, context)) if (filter(gid, &attr, context)) {
found = true; found = true;
if (index)
next: *index = i;
if (found)
break; break;
}
} }
read_unlock_irqrestore(&table->rwlock, flags); read_unlock_irqrestore(&table->rwlock, flags);
if (!found) if (!found)
return -ENOENT; return -ENOENT;
if (index)
*index = i;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment