Commit 154ac5a8 authored by Li Hong's avatar Li Hong Committed by Ryusuke Konishi

nilfs2: remove nilfs_segctor_init() in segment.c

There are only two lines of code in nilfs_segctor_init(). From a logic
design view, the first line 'sci->sc_seq_done = sci->sc_seq_request;'
should be put in nilfs_segctor_new(). Even in nilfs_segctor_new(),
this initialization is needless because sci is kzalloc-ed. So
nilfs_segctor_init() is only a wrap call to
nilfs_segctor_start_thread().
Signed-off-by: default avatarLi Hong <lihong.hi@gmail.com>
Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
parent 50614bcf
...@@ -2685,13 +2685,6 @@ static void nilfs_segctor_kill_thread(struct nilfs_sc_info *sci) ...@@ -2685,13 +2685,6 @@ static void nilfs_segctor_kill_thread(struct nilfs_sc_info *sci)
} }
} }
static int nilfs_segctor_init(struct nilfs_sc_info *sci)
{
sci->sc_seq_done = sci->sc_seq_request;
return nilfs_segctor_start_thread(sci);
}
/* /*
* Setup & clean-up functions * Setup & clean-up functions
*/ */
...@@ -2815,7 +2808,7 @@ int nilfs_attach_segment_constructor(struct nilfs_sb_info *sbi) ...@@ -2815,7 +2808,7 @@ int nilfs_attach_segment_constructor(struct nilfs_sb_info *sbi)
return -ENOMEM; return -ENOMEM;
nilfs_attach_writer(nilfs, sbi); nilfs_attach_writer(nilfs, sbi);
err = nilfs_segctor_init(NILFS_SC(sbi)); err = nilfs_segctor_start_thread(NILFS_SC(sbi));
if (err) { if (err) {
nilfs_detach_writer(nilfs, sbi); nilfs_detach_writer(nilfs, sbi);
kfree(sbi->s_sc_info); kfree(sbi->s_sc_info);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment