Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
linux
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
linux
Commits
1608a0fb
Commit
1608a0fb
authored
Nov 04, 2016
by
Ben Skeggs
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
drm/nouveau/fbcon: refcount the drm_framebuffer
Signed-off-by:
Ben Skeggs
<
bskeggs@redhat.com
>
parent
595b61cc
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
34 additions
and
38 deletions
+34
-38
drivers/gpu/drm/nouveau/nouveau_display.c
drivers/gpu/drm/nouveau/nouveau_display.c
+25
-28
drivers/gpu/drm/nouveau/nouveau_display.h
drivers/gpu/drm/nouveau/nouveau_display.h
+3
-2
drivers/gpu/drm/nouveau/nouveau_fbcon.c
drivers/gpu/drm/nouveau/nouveau_fbcon.c
+6
-7
drivers/gpu/drm/nouveau/nouveau_fbcon.h
drivers/gpu/drm/nouveau/nouveau_fbcon.h
+0
-1
No files found.
drivers/gpu/drm/nouveau/nouveau_display.c
View file @
1608a0fb
...
@@ -245,28 +245,32 @@ static const struct drm_framebuffer_funcs nouveau_framebuffer_funcs = {
...
@@ -245,28 +245,32 @@ static const struct drm_framebuffer_funcs nouveau_framebuffer_funcs = {
};
};
int
int
nouveau_framebuffer_init
(
struct
drm_device
*
dev
,
nouveau_framebuffer_new
(
struct
drm_device
*
dev
,
struct
nouveau_framebuffer
*
nv_fb
,
const
struct
drm_mode_fb_cmd2
*
mode_cmd
,
const
struct
drm_mode_fb_cmd2
*
mode_cmd
,
struct
nouveau_bo
*
nvbo
)
struct
nouveau_bo
*
nvbo
,
struct
nouveau_framebuffer
**
pfb
)
{
{
struct
nouveau_display
*
disp
=
nouveau_display
(
dev
);
struct
nouveau_display
*
disp
=
nouveau_display
(
dev
);
struct
drm_framebuffer
*
fb
=
&
nv_fb
->
base
;
struct
nouveau_framebuffer
*
fb
;
int
ret
;
int
ret
;
drm_helper_mode_fill_fb_struct
(
fb
,
mode_cmd
);
if
(
!
(
fb
=
kzalloc
(
sizeof
(
*
fb
),
GFP_KERNEL
)))
nv_fb
->
nvbo
=
nvbo
;
return
-
ENOMEM
;
ret
=
drm_framebuffer_init
(
dev
,
fb
,
&
nouveau_framebuffer_funcs
);
drm_helper_mode_fill_fb_struct
(
&
fb
->
base
,
mode_cmd
);
if
(
ret
)
fb
->
nvbo
=
nvbo
;
return
ret
;
if
(
disp
->
fb_ctor
)
{
ret
=
drm_framebuffer_init
(
dev
,
&
fb
->
base
,
&
nouveau_framebuffer_funcs
);
ret
=
disp
->
fb_ctor
(
fb
);
if
(
ret
==
0
)
{
if
(
ret
)
if
(
!
disp
->
fb_ctor
||
!
(
ret
=
disp
->
fb_ctor
(
&
fb
->
base
)))
{
disp
->
fb_dtor
(
fb
);
*
pfb
=
fb
;
return
0
;
}
disp
->
fb_dtor
(
&
fb
->
base
);
drm_framebuffer_cleanup
(
&
fb
->
base
);
}
}
kfree
(
fb
);
return
ret
;
return
ret
;
}
}
...
@@ -275,27 +279,20 @@ nouveau_user_framebuffer_create(struct drm_device *dev,
...
@@ -275,27 +279,20 @@ nouveau_user_framebuffer_create(struct drm_device *dev,
struct
drm_file
*
file_priv
,
struct
drm_file
*
file_priv
,
const
struct
drm_mode_fb_cmd2
*
mode_cmd
)
const
struct
drm_mode_fb_cmd2
*
mode_cmd
)
{
{
struct
nouveau_framebuffer
*
nouveau_fb
;
struct
nouveau_framebuffer
*
fb
;
struct
nouveau_bo
*
nvbo
;
struct
drm_gem_object
*
gem
;
struct
drm_gem_object
*
gem
;
int
ret
=
-
ENOMEM
;
int
ret
;
gem
=
drm_gem_object_lookup
(
file_priv
,
mode_cmd
->
handles
[
0
]);
gem
=
drm_gem_object_lookup
(
file_priv
,
mode_cmd
->
handles
[
0
]);
if
(
!
gem
)
if
(
!
gem
)
return
ERR_PTR
(
-
ENOENT
);
return
ERR_PTR
(
-
ENOENT
);
nvbo
=
nouveau_gem_object
(
gem
);
nouveau_fb
=
kzalloc
(
sizeof
(
struct
nouveau_framebuffer
),
GFP_KERNEL
);
ret
=
nouveau_framebuffer_new
(
dev
,
mode_cmd
,
nvbo
,
&
fb
);
if
(
!
nouveau_fb
)
if
(
ret
==
0
)
goto
err_unref
;
return
&
fb
->
base
;
ret
=
nouveau_framebuffer_init
(
dev
,
nouveau_fb
,
mode_cmd
,
nouveau_gem_object
(
gem
));
if
(
ret
)
goto
err
;
return
&
nouveau_fb
->
base
;
err:
kfree
(
nouveau_fb
);
err_unref:
drm_gem_object_unreference_unlocked
(
gem
);
drm_gem_object_unreference_unlocked
(
gem
);
return
ERR_PTR
(
ret
);
return
ERR_PTR
(
ret
);
}
}
...
...
drivers/gpu/drm/nouveau/nouveau_display.h
View file @
1608a0fb
...
@@ -22,8 +22,9 @@ nouveau_framebuffer(struct drm_framebuffer *fb)
...
@@ -22,8 +22,9 @@ nouveau_framebuffer(struct drm_framebuffer *fb)
return
container_of
(
fb
,
struct
nouveau_framebuffer
,
base
);
return
container_of
(
fb
,
struct
nouveau_framebuffer
,
base
);
}
}
int
nouveau_framebuffer_init
(
struct
drm_device
*
,
struct
nouveau_framebuffer
*
,
int
nouveau_framebuffer_new
(
struct
drm_device
*
,
const
struct
drm_mode_fb_cmd2
*
,
struct
nouveau_bo
*
);
const
struct
drm_mode_fb_cmd2
*
,
struct
nouveau_bo
*
,
struct
nouveau_framebuffer
**
);
struct
nouveau_page_flip_state
{
struct
nouveau_page_flip_state
{
struct
list_head
head
;
struct
list_head
head
;
...
...
drivers/gpu/drm/nouveau/nouveau_fbcon.c
View file @
1608a0fb
...
@@ -359,8 +359,9 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
...
@@ -359,8 +359,9 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
goto
out
;
goto
out
;
}
}
nouveau_framebuffer_init
(
dev
,
&
fbcon
->
fb
,
&
mode_cmd
,
nvbo
);
ret
=
nouveau_framebuffer_new
(
dev
,
&
mode_cmd
,
nvbo
,
&
fb
);
fb
=
&
fbcon
->
fb
;
if
(
ret
)
goto
out_unref
;
ret
=
nouveau_bo_pin
(
nvbo
,
TTM_PL_FLAG_VRAM
,
false
);
ret
=
nouveau_bo_pin
(
nvbo
,
TTM_PL_FLAG_VRAM
,
false
);
if
(
ret
)
{
if
(
ret
)
{
...
@@ -454,17 +455,15 @@ nouveau_fbcon_destroy(struct drm_device *dev, struct nouveau_fbdev *fbcon)
...
@@ -454,17 +455,15 @@ nouveau_fbcon_destroy(struct drm_device *dev, struct nouveau_fbdev *fbcon)
drm_fb_helper_unregister_fbi
(
&
fbcon
->
helper
);
drm_fb_helper_unregister_fbi
(
&
fbcon
->
helper
);
drm_fb_helper_release_fbi
(
&
fbcon
->
helper
);
drm_fb_helper_release_fbi
(
&
fbcon
->
helper
);
drm_fb_helper_fini
(
&
fbcon
->
helper
);
if
(
nouveau_fb
->
nvbo
)
{
if
(
nouveau_fb
->
nvbo
)
{
nouveau_bo_vma_del
(
nouveau_fb
->
nvbo
,
&
nouveau_fb
->
vma
);
nouveau_bo_vma_del
(
nouveau_fb
->
nvbo
,
&
nouveau_fb
->
vma
);
nouveau_bo_unmap
(
nouveau_fb
->
nvbo
);
nouveau_bo_unmap
(
nouveau_fb
->
nvbo
);
nouveau_bo_unpin
(
nouveau_fb
->
nvbo
);
nouveau_bo_unpin
(
nouveau_fb
->
nvbo
);
drm_gem_object_unreference_unlocked
(
&
nouveau_fb
->
nvbo
->
gem
);
drm_framebuffer_unreference
(
&
nouveau_fb
->
base
);
nouveau_fb
->
nvbo
=
NULL
;
}
}
drm_fb_helper_fini
(
&
fbcon
->
helper
);
drm_framebuffer_unregister_private
(
&
nouveau_fb
->
base
);
drm_framebuffer_cleanup
(
&
nouveau_fb
->
base
);
return
0
;
return
0
;
}
}
...
...
drivers/gpu/drm/nouveau/nouveau_fbcon.h
View file @
1608a0fb
...
@@ -33,7 +33,6 @@
...
@@ -33,7 +33,6 @@
struct
nouveau_fbdev
{
struct
nouveau_fbdev
{
struct
drm_fb_helper
helper
;
struct
drm_fb_helper
helper
;
struct
nouveau_framebuffer
fb
;
unsigned
int
saved_flags
;
unsigned
int
saved_flags
;
struct
nvif_object
surf2d
;
struct
nvif_object
surf2d
;
struct
nvif_object
clip
;
struct
nvif_object
clip
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment