Commit 19a0b67a authored by Dean Nelson's avatar Dean Nelson Committed by Jeff Kirsher

e1000: fix return value not set on error

Dean noticed that 'err' wasn't being set when the "goto err_dma"
statement is executed in the following hunk from the commit. It's value
will be zero as a result of a successful call to e1000_init_hw_struct().

This patch changes the error condition to be correctly propagated.

CC: stable@kernel.org
Signed-off-by: default avatarDean Nelson <dnelson@redhat.com>
Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent fa795e6b
...@@ -971,11 +971,13 @@ static int __devinit e1000_probe(struct pci_dev *pdev, ...@@ -971,11 +971,13 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
*/ */
dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64)); dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64));
pci_using_dac = 1; pci_using_dac = 1;
} else if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(32))) {
dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
} else { } else {
pr_err("No usable DMA config, aborting\n"); err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
goto err_dma; if (err) {
pr_err("No usable DMA config, aborting\n");
goto err_dma;
}
dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
} }
netdev->netdev_ops = &e1000_netdev_ops; netdev->netdev_ops = &e1000_netdev_ops;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment