Commit 1c4c3b99 authored by Jiang Biao's avatar Jiang Biao Committed by Linus Torvalds

mm: fix page_freeze_refs and page_unfreeze_refs in comments

page_freeze_refs/page_unfreeze_refs have already been relplaced by
page_ref_freeze/page_ref_unfreeze , but they are not modified in the
comments.

Link: http://lkml.kernel.org/r/1532590226-106038-1-git-send-email-jiang.biao2@zte.com.cnSigned-off-by: default avatarJiang Biao <jiang.biao2@zte.com.cn>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 8c9a134c
...@@ -703,7 +703,7 @@ static struct page *get_ksm_page(struct stable_node *stable_node, bool lock_it) ...@@ -703,7 +703,7 @@ static struct page *get_ksm_page(struct stable_node *stable_node, bool lock_it)
* We cannot do anything with the page while its refcount is 0. * We cannot do anything with the page while its refcount is 0.
* Usually 0 means free, or tail of a higher-order page: in which * Usually 0 means free, or tail of a higher-order page: in which
* case this node is no longer referenced, and should be freed; * case this node is no longer referenced, and should be freed;
* however, it might mean that the page is under page_freeze_refs(). * however, it might mean that the page is under page_ref_freeze().
* The __remove_mapping() case is easy, again the node is now stale; * The __remove_mapping() case is easy, again the node is now stale;
* but if page is swapcache in migrate_page_move_mapping(), it might * but if page is swapcache in migrate_page_move_mapping(), it might
* still be our page, in which case it's essential to keep the node. * still be our page, in which case it's essential to keep the node.
...@@ -714,7 +714,7 @@ static struct page *get_ksm_page(struct stable_node *stable_node, bool lock_it) ...@@ -714,7 +714,7 @@ static struct page *get_ksm_page(struct stable_node *stable_node, bool lock_it)
* work here too. We have chosen the !PageSwapCache test to * work here too. We have chosen the !PageSwapCache test to
* optimize the common case, when the page is or is about to * optimize the common case, when the page is or is about to
* be freed: PageSwapCache is cleared (under spin_lock_irq) * be freed: PageSwapCache is cleared (under spin_lock_irq)
* in the freeze_refs section of __remove_mapping(); but Anon * in the ref_freeze section of __remove_mapping(); but Anon
* page->mapping reset to NULL later, in free_pages_prepare(). * page->mapping reset to NULL later, in free_pages_prepare().
*/ */
if (!PageSwapCache(page)) if (!PageSwapCache(page))
......
...@@ -1167,7 +1167,7 @@ int memory_failure(unsigned long pfn, int flags) ...@@ -1167,7 +1167,7 @@ int memory_failure(unsigned long pfn, int flags)
* R/W the page; let's pray that the page has been * R/W the page; let's pray that the page has been
* used and will be freed some time later. * used and will be freed some time later.
* In fact it's dangerous to directly bump up page count from 0, * In fact it's dangerous to directly bump up page count from 0,
* that may make page_freeze_refs()/page_unfreeze_refs() mismatch. * that may make page_ref_freeze()/page_ref_unfreeze() mismatch.
*/ */
if (!(flags & MF_COUNT_INCREASED) && !get_hwpoison_page(p)) { if (!(flags & MF_COUNT_INCREASED) && !get_hwpoison_page(p)) {
if (is_free_buddy_page(p)) { if (is_free_buddy_page(p)) {
......
...@@ -903,7 +903,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page, ...@@ -903,7 +903,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page,
refcount = 2; refcount = 2;
if (!page_ref_freeze(page, refcount)) if (!page_ref_freeze(page, refcount))
goto cannot_free; goto cannot_free;
/* note: atomic_cmpxchg in page_freeze_refs provides the smp_rmb */ /* note: atomic_cmpxchg in page_ref_freeze provides the smp_rmb */
if (unlikely(PageDirty(page))) { if (unlikely(PageDirty(page))) {
page_ref_unfreeze(page, refcount); page_ref_unfreeze(page, refcount);
goto cannot_free; goto cannot_free;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment