Commit 1d8b4c95 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Mark Brown

spi: spi-fsl-dspi: Parameterize the FIFO size and DMA buffer size

Get rid of the ifdef for Coldfire and make these hardware
characteristics part of dspi->devtype_data.
Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Message-Id: <20200302001958.11105-4-olteanv@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d3505401
...@@ -20,13 +20,6 @@ ...@@ -20,13 +20,6 @@
#define DRIVER_NAME "fsl-dspi" #define DRIVER_NAME "fsl-dspi"
#ifdef CONFIG_M5441x
#define DSPI_FIFO_SIZE 16
#else
#define DSPI_FIFO_SIZE 4
#endif
#define DSPI_DMA_BUFSIZE (DSPI_FIFO_SIZE * 1024)
#define SPI_MCR 0x00 #define SPI_MCR 0x00
#define SPI_MCR_MASTER BIT(31) #define SPI_MCR_MASTER BIT(31)
#define SPI_MCR_PCSIS (0x3F << 16) #define SPI_MCR_PCSIS (0x3F << 16)
...@@ -131,6 +124,8 @@ struct fsl_dspi_devtype_data { ...@@ -131,6 +124,8 @@ struct fsl_dspi_devtype_data {
u8 max_clock_factor; u8 max_clock_factor;
bool ptp_sts_supported; bool ptp_sts_supported;
bool xspi_mode; bool xspi_mode;
int fifo_size;
int dma_bufsize;
}; };
enum { enum {
...@@ -149,54 +144,64 @@ static const struct fsl_dspi_devtype_data devtype_data[] = { ...@@ -149,54 +144,64 @@ static const struct fsl_dspi_devtype_data devtype_data[] = {
[VF610] = { [VF610] = {
.trans_mode = DSPI_DMA_MODE, .trans_mode = DSPI_DMA_MODE,
.max_clock_factor = 2, .max_clock_factor = 2,
.dma_bufsize = 4096,
.fifo_size = 4,
}, },
[LS1021A] = { [LS1021A] = {
.trans_mode = DSPI_TCFQ_MODE, .trans_mode = DSPI_TCFQ_MODE,
.max_clock_factor = 8, .max_clock_factor = 8,
.ptp_sts_supported = true, .ptp_sts_supported = true,
.xspi_mode = true, .xspi_mode = true,
.fifo_size = 4,
}, },
[LS1012A] = { [LS1012A] = {
.trans_mode = DSPI_TCFQ_MODE, .trans_mode = DSPI_TCFQ_MODE,
.max_clock_factor = 8, .max_clock_factor = 8,
.ptp_sts_supported = true, .ptp_sts_supported = true,
.xspi_mode = true, .xspi_mode = true,
.fifo_size = 16,
}, },
[LS1043A] = { [LS1043A] = {
.trans_mode = DSPI_TCFQ_MODE, .trans_mode = DSPI_TCFQ_MODE,
.max_clock_factor = 8, .max_clock_factor = 8,
.ptp_sts_supported = true, .ptp_sts_supported = true,
.xspi_mode = true, .xspi_mode = true,
.fifo_size = 16,
}, },
[LS1046A] = { [LS1046A] = {
.trans_mode = DSPI_TCFQ_MODE, .trans_mode = DSPI_TCFQ_MODE,
.max_clock_factor = 8, .max_clock_factor = 8,
.ptp_sts_supported = true, .ptp_sts_supported = true,
.xspi_mode = true, .xspi_mode = true,
.fifo_size = 16,
}, },
[LS2080A] = { [LS2080A] = {
.trans_mode = DSPI_TCFQ_MODE, .trans_mode = DSPI_TCFQ_MODE,
.max_clock_factor = 8, .max_clock_factor = 8,
.ptp_sts_supported = true, .ptp_sts_supported = true,
.fifo_size = 4,
}, },
[LS2085A] = { [LS2085A] = {
.trans_mode = DSPI_TCFQ_MODE, .trans_mode = DSPI_TCFQ_MODE,
.max_clock_factor = 8, .max_clock_factor = 8,
.ptp_sts_supported = true, .ptp_sts_supported = true,
.fifo_size = 4,
}, },
[LX2160A] = { [LX2160A] = {
.trans_mode = DSPI_TCFQ_MODE, .trans_mode = DSPI_TCFQ_MODE,
.max_clock_factor = 8, .max_clock_factor = 8,
.ptp_sts_supported = true, .ptp_sts_supported = true,
.fifo_size = 4,
}, },
[MCF5441X] = { [MCF5441X] = {
.trans_mode = DSPI_EOQ_MODE, .trans_mode = DSPI_EOQ_MODE,
.max_clock_factor = 8, .max_clock_factor = 8,
.fifo_size = 16,
}, },
}; };
struct fsl_dspi_dma { struct fsl_dspi_dma {
/* Length of transfer in words of DSPI_FIFO_SIZE */ /* Length of transfer in words of dspi->fifo_size */
u32 curr_xfer_len; u32 curr_xfer_len;
u32 *tx_dma_buf; u32 *tx_dma_buf;
...@@ -397,7 +402,8 @@ static int dspi_dma_xfer(struct fsl_dspi *dspi) ...@@ -397,7 +402,8 @@ static int dspi_dma_xfer(struct fsl_dspi *dspi)
int ret = 0; int ret = 0;
curr_remaining_bytes = dspi->len; curr_remaining_bytes = dspi->len;
bytes_per_buffer = DSPI_DMA_BUFSIZE / DSPI_FIFO_SIZE; bytes_per_buffer = dspi->devtype_data->dma_bufsize /
dspi->devtype_data->fifo_size;
while (curr_remaining_bytes) { while (curr_remaining_bytes) {
/* Check if current transfer fits the DMA buffer */ /* Check if current transfer fits the DMA buffer */
dma->curr_xfer_len = curr_remaining_bytes dma->curr_xfer_len = curr_remaining_bytes
...@@ -449,14 +455,14 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) ...@@ -449,14 +455,14 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr)
goto err_tx_channel; goto err_tx_channel;
} }
dma->tx_dma_buf = dma_alloc_coherent(dev, DSPI_DMA_BUFSIZE, dma->tx_dma_buf = dma_alloc_coherent(dev, dspi->devtype_data->dma_bufsize,
&dma->tx_dma_phys, GFP_KERNEL); &dma->tx_dma_phys, GFP_KERNEL);
if (!dma->tx_dma_buf) { if (!dma->tx_dma_buf) {
ret = -ENOMEM; ret = -ENOMEM;
goto err_tx_dma_buf; goto err_tx_dma_buf;
} }
dma->rx_dma_buf = dma_alloc_coherent(dev, DSPI_DMA_BUFSIZE, dma->rx_dma_buf = dma_alloc_coherent(dev, dspi->devtype_data->dma_bufsize,
&dma->rx_dma_phys, GFP_KERNEL); &dma->rx_dma_phys, GFP_KERNEL);
if (!dma->rx_dma_buf) { if (!dma->rx_dma_buf) {
ret = -ENOMEM; ret = -ENOMEM;
...@@ -493,10 +499,10 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) ...@@ -493,10 +499,10 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr)
return 0; return 0;
err_slave_config: err_slave_config:
dma_free_coherent(dev, DSPI_DMA_BUFSIZE, dma_free_coherent(dev, dspi->devtype_data->dma_bufsize,
dma->rx_dma_buf, dma->rx_dma_phys); dma->rx_dma_buf, dma->rx_dma_phys);
err_rx_dma_buf: err_rx_dma_buf:
dma_free_coherent(dev, DSPI_DMA_BUFSIZE, dma_free_coherent(dev, dspi->devtype_data->dma_bufsize,
dma->tx_dma_buf, dma->tx_dma_phys); dma->tx_dma_buf, dma->tx_dma_phys);
err_tx_dma_buf: err_tx_dma_buf:
dma_release_channel(dma->chan_tx); dma_release_channel(dma->chan_tx);
...@@ -519,13 +525,15 @@ static void dspi_release_dma(struct fsl_dspi *dspi) ...@@ -519,13 +525,15 @@ static void dspi_release_dma(struct fsl_dspi *dspi)
if (dma->chan_tx) { if (dma->chan_tx) {
dma_unmap_single(dev, dma->tx_dma_phys, dma_unmap_single(dev, dma->tx_dma_phys,
DSPI_DMA_BUFSIZE, DMA_TO_DEVICE); dspi->devtype_data->dma_bufsize,
DMA_TO_DEVICE);
dma_release_channel(dma->chan_tx); dma_release_channel(dma->chan_tx);
} }
if (dma->chan_rx) { if (dma->chan_rx) {
dma_unmap_single(dev, dma->rx_dma_phys, dma_unmap_single(dev, dma->rx_dma_phys,
DSPI_DMA_BUFSIZE, DMA_FROM_DEVICE); dspi->devtype_data->dma_bufsize,
DMA_FROM_DEVICE);
dma_release_channel(dma->chan_rx); dma_release_channel(dma->chan_rx);
} }
} }
...@@ -657,7 +665,7 @@ static void dspi_tcfq_read(struct fsl_dspi *dspi) ...@@ -657,7 +665,7 @@ static void dspi_tcfq_read(struct fsl_dspi *dspi)
static void dspi_eoq_write(struct fsl_dspi *dspi) static void dspi_eoq_write(struct fsl_dspi *dspi)
{ {
int fifo_size = DSPI_FIFO_SIZE; int fifo_size = dspi->devtype_data->fifo_size;
u16 xfer_cmd = dspi->tx_cmd; u16 xfer_cmd = dspi->tx_cmd;
/* Fill TX FIFO with as many transfers as possible */ /* Fill TX FIFO with as many transfers as possible */
...@@ -667,7 +675,7 @@ static void dspi_eoq_write(struct fsl_dspi *dspi) ...@@ -667,7 +675,7 @@ static void dspi_eoq_write(struct fsl_dspi *dspi)
if (dspi->len == dspi->bytes_per_word || fifo_size == 0) if (dspi->len == dspi->bytes_per_word || fifo_size == 0)
dspi->tx_cmd |= SPI_PUSHR_CMD_EOQ; dspi->tx_cmd |= SPI_PUSHR_CMD_EOQ;
/* Clear transfer count for first transfer in FIFO */ /* Clear transfer count for first transfer in FIFO */
if (fifo_size == (DSPI_FIFO_SIZE - 1)) if (fifo_size == (dspi->devtype_data->fifo_size - 1))
dspi->tx_cmd |= SPI_PUSHR_CMD_CTCNT; dspi->tx_cmd |= SPI_PUSHR_CMD_CTCNT;
/* Write combined TX FIFO and CMD FIFO entry */ /* Write combined TX FIFO and CMD FIFO entry */
fifo_write(dspi); fifo_write(dspi);
...@@ -676,7 +684,7 @@ static void dspi_eoq_write(struct fsl_dspi *dspi) ...@@ -676,7 +684,7 @@ static void dspi_eoq_write(struct fsl_dspi *dspi)
static void dspi_eoq_read(struct fsl_dspi *dspi) static void dspi_eoq_read(struct fsl_dspi *dspi)
{ {
int fifo_size = DSPI_FIFO_SIZE; int fifo_size = dspi->devtype_data->fifo_size;
/* Read one FIFO entry and push to rx buffer */ /* Read one FIFO entry and push to rx buffer */
while ((dspi->rx < dspi->rx_end) && fifo_size--) while ((dspi->rx < dspi->rx_end) && fifo_size--)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment