Commit 1e7d359d authored by Tahsin Erdogan's avatar Tahsin Erdogan Committed by Theodore Ts'o

ext4: fix ref counting for ea_inode

The ref count on ea_inode is incremented by
ext4_xattr_inode_orphan_add() which is supposed to be decremented by
ext4_xattr_inode_array_free(). The decrement is conditioned on whether
the ea_inode is currently on the orphan list. However, the orphan list
addition only happens when journaling is enabled. In non-journaled case,r
we fail to release the ref count causing an error message like below.

"VFS: Busy inodes after unmount of sdb. Self-destruct in 5 seconds.
Have a nice day..."
Signed-off-by: default avatarTahsin Erdogan <tahsin@google.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent ddfa17e4
...@@ -2096,8 +2096,7 @@ ext4_xattr_inode_array_free(struct inode *inode, ...@@ -2096,8 +2096,7 @@ ext4_xattr_inode_array_free(struct inode *inode,
if (err) if (err)
continue; continue;
/* for inode's i_count get from ext4_xattr_delete_inode */ /* for inode's i_count get from ext4_xattr_delete_inode */
if (!list_empty(&EXT4_I(ea_inode)->i_orphan)) iput(ea_inode);
iput(ea_inode);
clear_nlink(ea_inode); clear_nlink(ea_inode);
iput(ea_inode); iput(ea_inode);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment