Commit 1e881002 authored by Konrad Zapalowicz's avatar Konrad Zapalowicz Committed by Greg Kroah-Hartman

staging: dgnc: Fix externs should be avoided in the .c files

This commit fixes the following checkpatch warnings:

WARNING: externs should be avoided in .c files
    #80: FILE: drivers/staging/dgnc/dgnc_driver.c:80:
        +int            dgnc_init_module(void);
    #81: FILE: drivers/staging/dgnc/dgnc_driver.c:81:
        +void           dgnc_cleanup_module(void);

This was caused by putting the declarations for module init and module
exit fucntions on the top of the file. The fix removes these
declarations plus it also corrects the type of the init/exit functions.

Due to the dependency between init and exit functions the
dgnc_cleanup_module had to be put first.
Signed-off-by: default avatarKonrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d14b7123
...@@ -76,12 +76,6 @@ static void dgnc_remove_one(struct pci_dev *dev); ...@@ -76,12 +76,6 @@ static void dgnc_remove_one(struct pci_dev *dev);
static int dgnc_probe1(struct pci_dev *pdev, int card_type); static int dgnc_probe1(struct pci_dev *pdev, int card_type);
static void dgnc_do_remap(struct dgnc_board *brd); static void dgnc_do_remap(struct dgnc_board *brd);
/* Driver load/unload functions */
int dgnc_init_module(void);
void dgnc_cleanup_module(void);
module_init(dgnc_init_module);
module_exit(dgnc_cleanup_module);
/* /*
...@@ -199,13 +193,49 @@ char *dgnc_driver_state_text[] = { ...@@ -199,13 +193,49 @@ char *dgnc_driver_state_text[] = {
* *
************************************************************************/ ************************************************************************/
/*
* dgnc_cleanup_module()
*
* Module unload. This is where it all ends.
*/
static void dgnc_cleanup_module(void)
{
int i;
ulong lock_flags;
DGNC_LOCK(dgnc_poll_lock, lock_flags);
dgnc_poll_stop = 1;
DGNC_UNLOCK(dgnc_poll_lock, lock_flags);
/* Turn off poller right away. */
del_timer_sync(&dgnc_poll_timer);
dgnc_remove_driver_sysfiles(&dgnc_driver);
if (dgnc_Major_Control_Registered) {
device_destroy(dgnc_class, MKDEV(dgnc_Major, 0));
class_destroy(dgnc_class);
unregister_chrdev(dgnc_Major, "dgnc");
}
for (i = 0; i < dgnc_NumBoards; ++i) {
dgnc_remove_ports_sysfiles(dgnc_Board[i]);
dgnc_tty_uninit(dgnc_Board[i]);
dgnc_cleanup_board(dgnc_Board[i]);
}
dgnc_tty_post_uninit();
if (dgnc_NumBoards)
pci_unregister_driver(&dgnc_driver);
}
/* /*
* init_module() * init_module()
* *
* Module load. This is where it all starts. * Module load. This is where it all starts.
*/ */
int dgnc_init_module(void) static int __init dgnc_init_module(void)
{ {
int rc = 0; int rc = 0;
...@@ -243,6 +273,8 @@ int dgnc_init_module(void) ...@@ -243,6 +273,8 @@ int dgnc_init_module(void)
return rc; return rc;
} }
module_init(dgnc_init_module);
module_exit(dgnc_cleanup_module);
/* /*
* Start of driver. * Start of driver.
...@@ -354,44 +386,6 @@ static void dgnc_remove_one(struct pci_dev *dev) ...@@ -354,44 +386,6 @@ static void dgnc_remove_one(struct pci_dev *dev)
/* Do Nothing */ /* Do Nothing */
} }
/*
* dgnc_cleanup_module()
*
* Module unload. This is where it all ends.
*/
void dgnc_cleanup_module(void)
{
int i;
ulong lock_flags;
DGNC_LOCK(dgnc_poll_lock, lock_flags);
dgnc_poll_stop = 1;
DGNC_UNLOCK(dgnc_poll_lock, lock_flags);
/* Turn off poller right away. */
del_timer_sync(&dgnc_poll_timer);
dgnc_remove_driver_sysfiles(&dgnc_driver);
if (dgnc_Major_Control_Registered) {
device_destroy(dgnc_class, MKDEV(dgnc_Major, 0));
class_destroy(dgnc_class);
unregister_chrdev(dgnc_Major, "dgnc");
}
for (i = 0; i < dgnc_NumBoards; ++i) {
dgnc_remove_ports_sysfiles(dgnc_Board[i]);
dgnc_tty_uninit(dgnc_Board[i]);
dgnc_cleanup_board(dgnc_Board[i]);
}
dgnc_tty_post_uninit();
if (dgnc_NumBoards)
pci_unregister_driver(&dgnc_driver);
}
/* /*
* dgnc_cleanup_board() * dgnc_cleanup_board()
* *
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment