Commit 1e937cdd authored by Toshi Kani's avatar Toshi Kani Committed by Vishal Verma

xfs: Add alignment check for DAX mount

When a partition is not aligned by 4KB, mount -o dax succeeds,
but any read/write access to the filesystem fails, except for
metadata update.

Call bdev_dax_supported() to perform proper precondition checks
which includes this partition alignment check.
Signed-off-by: default avatarToshi Kani <toshi.kani@hpe.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Boaz Harrosh <boaz@plexistor.com>
Signed-off-by: default avatarVishal Verma <vishal.l.verma@intel.com>
parent 284854be
...@@ -1558,14 +1558,12 @@ xfs_fs_fill_super( ...@@ -1558,14 +1558,12 @@ xfs_fs_fill_super(
if (mp->m_flags & XFS_MOUNT_DAX) { if (mp->m_flags & XFS_MOUNT_DAX) {
xfs_warn(mp, xfs_warn(mp,
"DAX enabled. Warning: EXPERIMENTAL, use at your own risk"); "DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
if (sb->s_blocksize != PAGE_SIZE) {
xfs_alert(mp, error = bdev_dax_supported(sb, sb->s_blocksize);
"Filesystem block size invalid for DAX Turning DAX off."); if (error) {
mp->m_flags &= ~XFS_MOUNT_DAX;
} else if (!sb->s_bdev->bd_disk->fops->direct_access) {
xfs_alert(mp, xfs_alert(mp,
"Block device does not support DAX Turning DAX off."); "DAX unsupported by block device. Turning off DAX.");
mp->m_flags &= ~XFS_MOUNT_DAX; mp->m_flags &= ~XFS_MOUNT_DAX;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment