Commit 1f3c3632 authored by Tiezhu Yang's avatar Tiezhu Yang Committed by Mark Brown

spi: spidev_test: Check input_tx and input_file first after parse options

It is better to check input_tx and input_file first after parse options.
Otherwise, it will do some useless operations when both -p and --input
are selected.
Signed-off-by: default avatarTiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/1581567368-8055-2-git-send-email-yangtiezhu@loongson.cnSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 020bd6c4
...@@ -404,6 +404,9 @@ int main(int argc, char *argv[]) ...@@ -404,6 +404,9 @@ int main(int argc, char *argv[])
parse_opts(argc, argv); parse_opts(argc, argv);
if (input_tx && input_file)
pabort("only one of -p and --input may be selected");
fd = open(device, O_RDWR); fd = open(device, O_RDWR);
if (fd < 0) if (fd < 0)
pabort("can't open device"); pabort("can't open device");
...@@ -445,9 +448,6 @@ int main(int argc, char *argv[]) ...@@ -445,9 +448,6 @@ int main(int argc, char *argv[])
printf("bits per word: %d\n", bits); printf("bits per word: %d\n", bits);
printf("max speed: %d Hz (%d KHz)\n", speed, speed/1000); printf("max speed: %d Hz (%d KHz)\n", speed, speed/1000);
if (input_tx && input_file)
pabort("only one of -p and --input may be selected");
if (input_tx) if (input_tx)
transfer_escaped_string(fd, input_tx); transfer_escaped_string(fd, input_tx);
else if (input_file) else if (input_file)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment