Commit 2045ceae authored by stephen hemminger's avatar stephen hemminger Committed by David S. Miller

net: remove unnecessary return's

One of my pet coding style peeves is the practice of
adding extra return; at the end of function.
Kill several instances of this in network code.

I suppose some coccinelle wizardy could do this automatically.
Signed-off-by: default avatarStephen Hemminger <stephen@networkplumber.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 45f74359
...@@ -389,8 +389,6 @@ void batadv_gw_check_election(struct batadv_priv *bat_priv, ...@@ -389,8 +389,6 @@ void batadv_gw_check_election(struct batadv_priv *bat_priv,
batadv_neigh_ifinfo_free_ref(router_gw_tq); batadv_neigh_ifinfo_free_ref(router_gw_tq);
if (router_orig_tq) if (router_orig_tq)
batadv_neigh_ifinfo_free_ref(router_orig_tq); batadv_neigh_ifinfo_free_ref(router_orig_tq);
return;
} }
/** /**
......
...@@ -2082,7 +2082,6 @@ void ceph_osdc_handle_map(struct ceph_osd_client *osdc, struct ceph_msg *msg) ...@@ -2082,7 +2082,6 @@ void ceph_osdc_handle_map(struct ceph_osd_client *osdc, struct ceph_msg *msg)
pr_err("osdc handle_map corrupt msg\n"); pr_err("osdc handle_map corrupt msg\n");
ceph_msg_dump(msg); ceph_msg_dump(msg);
up_write(&osdc->map_sem); up_write(&osdc->map_sem);
return;
} }
/* /*
...@@ -2281,7 +2280,6 @@ static void handle_watch_notify(struct ceph_osd_client *osdc, ...@@ -2281,7 +2280,6 @@ static void handle_watch_notify(struct ceph_osd_client *osdc,
bad: bad:
pr_err("osdc handle_watch_notify corrupt msg\n"); pr_err("osdc handle_watch_notify corrupt msg\n");
return;
} }
/* /*
......
...@@ -221,5 +221,4 @@ void reqsk_fastopen_remove(struct sock *sk, struct request_sock *req, ...@@ -221,5 +221,4 @@ void reqsk_fastopen_remove(struct sock *sk, struct request_sock *req,
out: out:
spin_unlock_bh(&fastopenq->lock); spin_unlock_bh(&fastopenq->lock);
sock_put(lsk); sock_put(lsk);
return;
} }
...@@ -697,7 +697,6 @@ static void update_or_create_fnhe(struct fib_nh *nh, __be32 daddr, __be32 gw, ...@@ -697,7 +697,6 @@ static void update_or_create_fnhe(struct fib_nh *nh, __be32 daddr, __be32 gw,
out_unlock: out_unlock:
spin_unlock_bh(&fnhe_lock); spin_unlock_bh(&fnhe_lock);
return;
} }
static void __ip_do_redirect(struct rtable *rt, struct sk_buff *skb, struct flowi4 *fl4, static void __ip_do_redirect(struct rtable *rt, struct sk_buff *skb, struct flowi4 *fl4,
......
...@@ -2071,7 +2071,6 @@ void tcp_send_loss_probe(struct sock *sk) ...@@ -2071,7 +2071,6 @@ void tcp_send_loss_probe(struct sock *sk)
if (likely(!err)) if (likely(!err))
NET_INC_STATS_BH(sock_net(sk), NET_INC_STATS_BH(sock_net(sk),
LINUX_MIB_TCPLOSSPROBES); LINUX_MIB_TCPLOSSPROBES);
return;
} }
/* Push out any pending frames which were held back due to /* Push out any pending frames which were held back due to
......
...@@ -1809,8 +1809,6 @@ void l2tp_session_free(struct l2tp_session *session) ...@@ -1809,8 +1809,6 @@ void l2tp_session_free(struct l2tp_session *session)
} }
kfree(session); kfree(session);
return;
} }
EXPORT_SYMBOL_GPL(l2tp_session_free); EXPORT_SYMBOL_GPL(l2tp_session_free);
......
...@@ -454,13 +454,11 @@ static void pppol2tp_session_close(struct l2tp_session *session) ...@@ -454,13 +454,11 @@ static void pppol2tp_session_close(struct l2tp_session *session)
BUG_ON(session->magic != L2TP_SESSION_MAGIC); BUG_ON(session->magic != L2TP_SESSION_MAGIC);
if (sock) { if (sock) {
inet_shutdown(sock, 2); inet_shutdown(sock, 2);
/* Don't let the session go away before our socket does */ /* Don't let the session go away before our socket does */
l2tp_session_inc_refcount(session); l2tp_session_inc_refcount(session);
} }
return;
} }
/* Really kill the session socket. (Called from sock_put() if /* Really kill the session socket. (Called from sock_put() if
...@@ -474,7 +472,6 @@ static void pppol2tp_session_destruct(struct sock *sk) ...@@ -474,7 +472,6 @@ static void pppol2tp_session_destruct(struct sock *sk)
BUG_ON(session->magic != L2TP_SESSION_MAGIC); BUG_ON(session->magic != L2TP_SESSION_MAGIC);
l2tp_session_dec_refcount(session); l2tp_session_dec_refcount(session);
} }
return;
} }
/* Called when the PPPoX socket (session) is closed. /* Called when the PPPoX socket (session) is closed.
......
...@@ -62,8 +62,6 @@ static void hw_addr_notify(struct work_struct *work) ...@@ -62,8 +62,6 @@ static void hw_addr_notify(struct work_struct *work)
pr_debug("failed changed mask %lx\n", nw->changed); pr_debug("failed changed mask %lx\n", nw->changed);
kfree(nw); kfree(nw);
return;
} }
static void set_hw_addr_filt(struct net_device *dev, unsigned long changed) static void set_hw_addr_filt(struct net_device *dev, unsigned long changed)
...@@ -79,8 +77,6 @@ static void set_hw_addr_filt(struct net_device *dev, unsigned long changed) ...@@ -79,8 +77,6 @@ static void set_hw_addr_filt(struct net_device *dev, unsigned long changed)
work->dev = dev; work->dev = dev;
work->changed = changed; work->changed = changed;
queue_work(priv->hw->dev_workqueue, &work->work); queue_work(priv->hw->dev_workqueue, &work->work);
return;
} }
void mac802154_dev_set_short_addr(struct net_device *dev, u16 val) void mac802154_dev_set_short_addr(struct net_device *dev, u16 val)
......
...@@ -80,7 +80,6 @@ mac802154_subif_rx(struct ieee802154_dev *hw, struct sk_buff *skb, u8 lqi) ...@@ -80,7 +80,6 @@ mac802154_subif_rx(struct ieee802154_dev *hw, struct sk_buff *skb, u8 lqi)
mac802154_wpans_rx(priv, skb); mac802154_wpans_rx(priv, skb);
out: out:
dev_kfree_skb(skb); dev_kfree_skb(skb);
return;
} }
static void mac802154_rx_worker(struct work_struct *work) static void mac802154_rx_worker(struct work_struct *work)
......
...@@ -652,5 +652,4 @@ void sctp_transport_immediate_rtx(struct sctp_transport *t) ...@@ -652,5 +652,4 @@ void sctp_transport_immediate_rtx(struct sctp_transport *t)
if (!mod_timer(&t->T3_rtx_timer, jiffies + t->rto)) if (!mod_timer(&t->T3_rtx_timer, jiffies + t->rto))
sctp_transport_hold(t); sctp_transport_hold(t);
} }
return;
} }
...@@ -701,6 +701,4 @@ cfg80211_get_chan_state(struct wireless_dev *wdev, ...@@ -701,6 +701,4 @@ cfg80211_get_chan_state(struct wireless_dev *wdev,
case NUM_NL80211_IFTYPES: case NUM_NL80211_IFTYPES:
WARN_ON(1); WARN_ON(1);
} }
return;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment