Commit 209ac85d authored by Adrian Bunk's avatar Adrian Bunk Committed by Jaroslav Kysela

[ALSA] sound/isa/: cleanups

GUS Library
This patch contains the following possible cleanups:
- make needlesly global code static
- #if 0 the following unused global functions:
  - gus/gus_volume.c: snd_gf1_gvol_to_lvol_raw
  - gus/gus_volume.c: snd_gf1_calc_ramp_rate
  - gus/gus_volume.c: snd_gf1_compute_vibrato
  - gus/gus_volume.c: snd_gf1_compute_pitchbend
  - gus/gus_volume.c: snd_gf1_compute_freq
  - gus/gus_io.c: snd_gf1_i_adlib_write
  - gus/gus_io.c: snd_gf1_i_write_addr
  - gus/gus_io.c: snd_gf1_pokew
  - gus/gus_io.c: snd_gf1_peekw
  - gus/gus_io.c: snd_gf1_dram_setmem
  - gus/gus_io.c: snd_gf1_print_global_registers
  - gus/gus_io.c: snd_gf1_print_setup_registers
  - gus/gus_io.c: snd_gf1_peek_print_block
  - gus/gus_io.c: snd_gf1_print_setup_registers
  - gus/gus_io.c: snd_gf1_peek_print_block
- #if 0 the following unused global variable:
  - gus/gus_tables.h: snd_gf1_scale_table
- remove the following unneeded EXPORT_SYMBOL's:
  - gus/gus_main.c: snd_gf1_i_write16
  - gus/gus_main.c: snd_gf1_start
  - gus/gus_main.c: snd_gf1_stop
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 1baa705b
...@@ -526,9 +526,6 @@ extern void snd_gf1_adlib_write(snd_gus_card_t * gus, unsigned char reg, unsigne ...@@ -526,9 +526,6 @@ extern void snd_gf1_adlib_write(snd_gus_card_t * gus, unsigned char reg, unsigne
extern void snd_gf1_dram_addr(snd_gus_card_t * gus, unsigned int addr); extern void snd_gf1_dram_addr(snd_gus_card_t * gus, unsigned int addr);
extern void snd_gf1_poke(snd_gus_card_t * gus, unsigned int addr, unsigned char data); extern void snd_gf1_poke(snd_gus_card_t * gus, unsigned int addr, unsigned char data);
extern unsigned char snd_gf1_peek(snd_gus_card_t * gus, unsigned int addr); extern unsigned char snd_gf1_peek(snd_gus_card_t * gus, unsigned int addr);
extern void snd_gf1_pokew(snd_gus_card_t * gus, unsigned int addr, unsigned short data);
extern unsigned short snd_gf1_peekw(snd_gus_card_t * gus, unsigned int addr);
extern void snd_gf1_dram_setmem(snd_gus_card_t * gus, unsigned int addr, unsigned short value, unsigned int count);
extern void snd_gf1_write_addr(snd_gus_card_t * gus, unsigned char reg, unsigned int addr, short w_16bit); extern void snd_gf1_write_addr(snd_gus_card_t * gus, unsigned char reg, unsigned int addr, short w_16bit);
extern unsigned int snd_gf1_read_addr(snd_gus_card_t * gus, unsigned char reg, short w_16bit); extern unsigned int snd_gf1_read_addr(snd_gus_card_t * gus, unsigned char reg, short w_16bit);
extern void snd_gf1_i_ctrl_stop(snd_gus_card_t * gus, unsigned char reg); extern void snd_gf1_i_ctrl_stop(snd_gus_card_t * gus, unsigned char reg);
...@@ -544,9 +541,6 @@ extern inline unsigned short snd_gf1_i_read16(snd_gus_card_t * gus, unsigned cha ...@@ -544,9 +541,6 @@ extern inline unsigned short snd_gf1_i_read16(snd_gus_card_t * gus, unsigned cha
{ {
return snd_gf1_i_look16(gus, reg | 0x80); return snd_gf1_i_look16(gus, reg | 0x80);
} }
extern void snd_gf1_i_adlib_write(snd_gus_card_t * gus, unsigned char reg, unsigned char data);
extern void snd_gf1_i_write_addr(snd_gus_card_t * gus, unsigned char reg, unsigned int addr, short w_16bit);
extern unsigned int snd_gf1_i_read_addr(snd_gus_card_t * gus, unsigned char reg, short w_16bit);
extern void snd_gf1_select_active_voices(snd_gus_card_t * gus); extern void snd_gf1_select_active_voices(snd_gus_card_t * gus);
...@@ -580,10 +574,6 @@ extern void snd_gf1_lfo_command(snd_gus_card_t * gus, int voice, unsigned char * ...@@ -580,10 +574,6 @@ extern void snd_gf1_lfo_command(snd_gus_card_t * gus, int voice, unsigned char *
void snd_gf1_mem_lock(snd_gf1_mem_t * alloc, int xup); void snd_gf1_mem_lock(snd_gf1_mem_t * alloc, int xup);
int snd_gf1_mem_xfree(snd_gf1_mem_t * alloc, snd_gf1_mem_block_t * block); int snd_gf1_mem_xfree(snd_gf1_mem_t * alloc, snd_gf1_mem_block_t * block);
snd_gf1_mem_block_t *snd_gf1_mem_look(snd_gf1_mem_t * alloc,
unsigned int address);
snd_gf1_mem_block_t *snd_gf1_mem_share(snd_gf1_mem_t * alloc,
unsigned int *share_id);
snd_gf1_mem_block_t *snd_gf1_mem_alloc(snd_gf1_mem_t * alloc, int owner, snd_gf1_mem_block_t *snd_gf1_mem_alloc(snd_gf1_mem_t * alloc, int owner,
char *name, int size, int w_16, char *name, int size, int w_16,
int align, unsigned int *share_id); int align, unsigned int *share_id);
...@@ -608,23 +598,13 @@ int snd_gf1_dma_transfer_block(snd_gus_card_t * gus, ...@@ -608,23 +598,13 @@ int snd_gf1_dma_transfer_block(snd_gus_card_t * gus,
/* gus_volume.c */ /* gus_volume.c */
unsigned short snd_gf1_lvol_to_gvol_raw(unsigned int vol); unsigned short snd_gf1_lvol_to_gvol_raw(unsigned int vol);
unsigned int snd_gf1_gvol_to_lvol_raw(unsigned short gf1_vol);
unsigned int snd_gf1_calc_ramp_rate(snd_gus_card_t * gus,
unsigned short start,
unsigned short end,
unsigned int us);
unsigned short snd_gf1_translate_freq(snd_gus_card_t * gus, unsigned int freq2); unsigned short snd_gf1_translate_freq(snd_gus_card_t * gus, unsigned int freq2);
unsigned short snd_gf1_compute_pitchbend(unsigned short pitchbend, unsigned short sens);
unsigned short snd_gf1_compute_freq(unsigned int freq,
unsigned int rate,
unsigned short mix_rate);
/* gus_reset.c */ /* gus_reset.c */
void snd_gf1_set_default_handlers(snd_gus_card_t * gus, unsigned int what); void snd_gf1_set_default_handlers(snd_gus_card_t * gus, unsigned int what);
void snd_gf1_smart_stop_voice(snd_gus_card_t * gus, unsigned short voice); void snd_gf1_smart_stop_voice(snd_gus_card_t * gus, unsigned short voice);
void snd_gf1_stop_voice(snd_gus_card_t * gus, unsigned short voice); void snd_gf1_stop_voice(snd_gus_card_t * gus, unsigned short voice);
void snd_gf1_clear_voices(snd_gus_card_t * gus, unsigned short v_min, unsigned short v_max);
void snd_gf1_stop_voices(snd_gus_card_t * gus, unsigned short v_min, unsigned short v_max); void snd_gf1_stop_voices(snd_gus_card_t * gus, unsigned short v_min, unsigned short v_max);
snd_gus_voice_t *snd_gf1_alloc_voice(snd_gus_card_t * gus, int type, int client, int port); snd_gus_voice_t *snd_gf1_alloc_voice(snd_gus_card_t * gus, int type, int client, int port);
void snd_gf1_free_voice(snd_gus_card_t * gus, snd_gus_voice_t *voice); void snd_gf1_free_voice(snd_gus_card_t * gus, snd_gus_voice_t *voice);
...@@ -641,9 +621,6 @@ int snd_gf1_pcm_new(snd_gus_card_t * gus, int pcm_dev, int control_index, snd_pc ...@@ -641,9 +621,6 @@ int snd_gf1_pcm_new(snd_gus_card_t * gus, int pcm_dev, int control_index, snd_pc
#ifdef CONFIG_SND_DEBUG #ifdef CONFIG_SND_DEBUG
extern void snd_gf1_print_voice_registers(snd_gus_card_t * gus); extern void snd_gf1_print_voice_registers(snd_gus_card_t * gus);
extern void snd_gf1_print_global_registers(snd_gus_card_t * gus);
extern void snd_gf1_print_setup_registers(snd_gus_card_t * gus);
extern void snd_gf1_peek_print_block(snd_gus_card_t * gus, unsigned int addr, int count, int w_16bit);
#endif #endif
/* gus.c */ /* gus.c */
......
...@@ -244,6 +244,8 @@ unsigned short snd_gf1_i_look16(snd_gus_card_t * gus, unsigned char reg) ...@@ -244,6 +244,8 @@ unsigned short snd_gf1_i_look16(snd_gus_card_t * gus, unsigned char reg)
return res; return res;
} }
#if 0
void snd_gf1_i_adlib_write(snd_gus_card_t * gus, void snd_gf1_i_adlib_write(snd_gus_card_t * gus,
unsigned char reg, unsigned char reg,
unsigned char data) unsigned char data)
...@@ -265,6 +267,8 @@ void snd_gf1_i_write_addr(snd_gus_card_t * gus, unsigned char reg, ...@@ -265,6 +267,8 @@ void snd_gf1_i_write_addr(snd_gus_card_t * gus, unsigned char reg,
spin_unlock_irqrestore(&gus->reg_lock, flags); spin_unlock_irqrestore(&gus->reg_lock, flags);
} }
#endif /* 0 */
unsigned int snd_gf1_i_read_addr(snd_gus_card_t * gus, unsigned int snd_gf1_i_read_addr(snd_gus_card_t * gus,
unsigned char reg, short w_16bit) unsigned char reg, short w_16bit)
{ {
...@@ -329,6 +333,8 @@ unsigned char snd_gf1_peek(snd_gus_card_t * gus, unsigned int addr) ...@@ -329,6 +333,8 @@ unsigned char snd_gf1_peek(snd_gus_card_t * gus, unsigned int addr)
return res; return res;
} }
#if 0
void snd_gf1_pokew(snd_gus_card_t * gus, unsigned int addr, unsigned short data) void snd_gf1_pokew(snd_gus_card_t * gus, unsigned int addr, unsigned short data)
{ {
unsigned long flags; unsigned long flags;
...@@ -405,9 +411,7 @@ void snd_gf1_dram_setmem(snd_gus_card_t * gus, unsigned int addr, ...@@ -405,9 +411,7 @@ void snd_gf1_dram_setmem(snd_gus_card_t * gus, unsigned int addr,
spin_unlock_irqrestore(&gus->reg_lock, flags); spin_unlock_irqrestore(&gus->reg_lock, flags);
} }
/* #endif /* 0 */
*/
void snd_gf1_select_active_voices(snd_gus_card_t * gus) void snd_gf1_select_active_voices(snd_gus_card_t * gus)
{ {
...@@ -469,6 +473,8 @@ void snd_gf1_print_voice_registers(snd_gus_card_t * gus) ...@@ -469,6 +473,8 @@ void snd_gf1_print_voice_registers(snd_gus_card_t * gus)
printk(" -%i- GF1 pan = 0x%x\n", voice, snd_gf1_i_read8(gus, 0x0c)); printk(" -%i- GF1 pan = 0x%x\n", voice, snd_gf1_i_read8(gus, 0x0c));
} }
#if 0
void snd_gf1_print_global_registers(snd_gus_card_t * gus) void snd_gf1_print_global_registers(snd_gus_card_t * gus)
{ {
unsigned char global_mode = 0x00; unsigned char global_mode = 0x00;
...@@ -528,4 +534,6 @@ void snd_gf1_peek_print_block(snd_gus_card_t * gus, unsigned int addr, int count ...@@ -528,4 +534,6 @@ void snd_gf1_peek_print_block(snd_gus_card_t * gus, unsigned int addr, int count
} }
} }
#endif /* 0 */
#endif #endif
...@@ -459,7 +459,6 @@ EXPORT_SYMBOL(snd_gf1_write16); ...@@ -459,7 +459,6 @@ EXPORT_SYMBOL(snd_gf1_write16);
EXPORT_SYMBOL(snd_gf1_look16); EXPORT_SYMBOL(snd_gf1_look16);
EXPORT_SYMBOL(snd_gf1_i_write8); EXPORT_SYMBOL(snd_gf1_i_write8);
EXPORT_SYMBOL(snd_gf1_i_look8); EXPORT_SYMBOL(snd_gf1_i_look8);
EXPORT_SYMBOL(snd_gf1_i_write16);
EXPORT_SYMBOL(snd_gf1_i_look16); EXPORT_SYMBOL(snd_gf1_i_look16);
EXPORT_SYMBOL(snd_gf1_dram_addr); EXPORT_SYMBOL(snd_gf1_dram_addr);
EXPORT_SYMBOL(snd_gf1_write_addr); EXPORT_SYMBOL(snd_gf1_write_addr);
...@@ -470,8 +469,6 @@ EXPORT_SYMBOL(snd_gf1_alloc_voice); ...@@ -470,8 +469,6 @@ EXPORT_SYMBOL(snd_gf1_alloc_voice);
EXPORT_SYMBOL(snd_gf1_free_voice); EXPORT_SYMBOL(snd_gf1_free_voice);
EXPORT_SYMBOL(snd_gf1_ctrl_stop); EXPORT_SYMBOL(snd_gf1_ctrl_stop);
EXPORT_SYMBOL(snd_gf1_stop_voice); EXPORT_SYMBOL(snd_gf1_stop_voice);
EXPORT_SYMBOL(snd_gf1_start);
EXPORT_SYMBOL(snd_gf1_stop);
/* gus_mixer.c */ /* gus_mixer.c */
EXPORT_SYMBOL(snd_gf1_new_mixer); EXPORT_SYMBOL(snd_gf1_new_mixer);
/* gus_pcm.c */ /* gus_pcm.c */
......
...@@ -39,7 +39,7 @@ void snd_gf1_mem_lock(snd_gf1_mem_t * alloc, int xup) ...@@ -39,7 +39,7 @@ void snd_gf1_mem_lock(snd_gf1_mem_t * alloc, int xup)
} }
} }
snd_gf1_mem_block_t *snd_gf1_mem_xalloc(snd_gf1_mem_t * alloc, static snd_gf1_mem_block_t *snd_gf1_mem_xalloc(snd_gf1_mem_t * alloc,
snd_gf1_mem_block_t * block) snd_gf1_mem_block_t * block)
{ {
snd_gf1_mem_block_t *pblock, *nblock; snd_gf1_mem_block_t *pblock, *nblock;
...@@ -105,7 +105,7 @@ int snd_gf1_mem_xfree(snd_gf1_mem_t * alloc, snd_gf1_mem_block_t * block) ...@@ -105,7 +105,7 @@ int snd_gf1_mem_xfree(snd_gf1_mem_t * alloc, snd_gf1_mem_block_t * block)
return 0; return 0;
} }
snd_gf1_mem_block_t *snd_gf1_mem_look(snd_gf1_mem_t * alloc, static snd_gf1_mem_block_t *snd_gf1_mem_look(snd_gf1_mem_t * alloc,
unsigned int address) unsigned int address)
{ {
snd_gf1_mem_block_t *block; snd_gf1_mem_block_t *block;
...@@ -118,7 +118,7 @@ snd_gf1_mem_block_t *snd_gf1_mem_look(snd_gf1_mem_t * alloc, ...@@ -118,7 +118,7 @@ snd_gf1_mem_block_t *snd_gf1_mem_look(snd_gf1_mem_t * alloc,
return NULL; return NULL;
} }
snd_gf1_mem_block_t *snd_gf1_mem_share(snd_gf1_mem_t * alloc, static snd_gf1_mem_block_t *snd_gf1_mem_share(snd_gf1_mem_t * alloc,
unsigned int *share_id) unsigned int *share_id)
{ {
snd_gf1_mem_block_t *block; snd_gf1_mem_block_t *block;
......
...@@ -161,7 +161,8 @@ void snd_gf1_stop_voice(snd_gus_card_t * gus, unsigned short voice) ...@@ -161,7 +161,8 @@ void snd_gf1_stop_voice(snd_gus_card_t * gus, unsigned short voice)
#endif #endif
} }
void snd_gf1_clear_voices(snd_gus_card_t * gus, unsigned short v_min, unsigned short v_max) static void snd_gf1_clear_voices(snd_gus_card_t * gus, unsigned short v_min,
unsigned short v_max)
{ {
unsigned long flags; unsigned long flags;
unsigned int daddr; unsigned int daddr;
......
...@@ -99,7 +99,8 @@ static void snd_gus_synth_free_private_instruments(snd_gus_port_t *p, int client ...@@ -99,7 +99,8 @@ static void snd_gus_synth_free_private_instruments(snd_gus_port_t *p, int client
snd_seq_instr_list_free_cond(p->gus->gf1.ilist, &ifree, client, 0); snd_seq_instr_list_free_cond(p->gus->gf1.ilist, &ifree, client, 0);
} }
int snd_gus_synth_event_input(snd_seq_event_t *ev, int direct, void *private_data, int atomic, int hop) static int snd_gus_synth_event_input(snd_seq_event_t *ev, int direct,
void *private_data, int atomic, int hop)
{ {
snd_gus_port_t * p = (snd_gus_port_t *) private_data; snd_gus_port_t * p = (snd_gus_port_t *) private_data;
......
...@@ -23,6 +23,8 @@ ...@@ -23,6 +23,8 @@
#ifdef __GUS_TABLES_ALLOC__ #ifdef __GUS_TABLES_ALLOC__
#if 0
unsigned int snd_gf1_scale_table[SNDRV_GF1_SCALE_TABLE_SIZE] = unsigned int snd_gf1_scale_table[SNDRV_GF1_SCALE_TABLE_SIZE] =
{ {
8372, 8870, 9397, 9956, 10548, 11175, 8372, 8870, 9397, 9956, 10548, 11175,
...@@ -49,6 +51,8 @@ unsigned int snd_gf1_scale_table[SNDRV_GF1_SCALE_TABLE_SIZE] = ...@@ -49,6 +51,8 @@ unsigned int snd_gf1_scale_table[SNDRV_GF1_SCALE_TABLE_SIZE] =
12123977, 12844906 12123977, 12844906
}; };
#endif /* 0 */
unsigned short snd_gf1_atten_table[SNDRV_GF1_ATTEN_TABLE_SIZE] = { unsigned short snd_gf1_atten_table[SNDRV_GF1_ATTEN_TABLE_SIZE] = {
4095 /* 0 */,1789 /* 1 */,1533 /* 2 */,1383 /* 3 */,1277 /* 4 */, 4095 /* 0 */,1789 /* 1 */,1533 /* 2 */,1383 /* 3 */,1277 /* 4 */,
1195 /* 5 */,1127 /* 6 */,1070 /* 7 */,1021 /* 8 */,978 /* 9 */, 1195 /* 5 */,1127 /* 6 */,1070 /* 7 */,1021 /* 8 */,978 /* 9 */,
......
...@@ -55,6 +55,8 @@ unsigned short snd_gf1_lvol_to_gvol_raw(unsigned int vol) ...@@ -55,6 +55,8 @@ unsigned short snd_gf1_lvol_to_gvol_raw(unsigned int vol)
return (e << 8) | m; return (e << 8) | m;
} }
#if 0
unsigned int snd_gf1_gvol_to_lvol_raw(unsigned short gf1_vol) unsigned int snd_gf1_gvol_to_lvol_raw(unsigned short gf1_vol)
{ {
unsigned int rvol; unsigned int rvol;
...@@ -108,6 +110,8 @@ unsigned int snd_gf1_calc_ramp_rate(snd_gus_card_t * gus, ...@@ -108,6 +110,8 @@ unsigned int snd_gf1_calc_ramp_rate(snd_gus_card_t * gus,
return (range << 6) | (increment & 0x3f); return (range << 6) | (increment & 0x3f);
} }
#endif /* 0 */
unsigned short snd_gf1_translate_freq(snd_gus_card_t * gus, unsigned int freq16) unsigned short snd_gf1_translate_freq(snd_gus_card_t * gus, unsigned int freq16)
{ {
freq16 >>= 3; freq16 >>= 3;
...@@ -120,6 +124,8 @@ unsigned short snd_gf1_translate_freq(snd_gus_card_t * gus, unsigned int freq16) ...@@ -120,6 +124,8 @@ unsigned short snd_gf1_translate_freq(snd_gus_card_t * gus, unsigned int freq16)
return ((freq16 << 9) + (gus->gf1.playback_freq >> 1)) / gus->gf1.playback_freq; return ((freq16 << 9) + (gus->gf1.playback_freq >> 1)) / gus->gf1.playback_freq;
} }
#if 0
short snd_gf1_compute_vibrato(short cents, unsigned short fc_register) short snd_gf1_compute_vibrato(short cents, unsigned short fc_register)
{ {
static short vibrato_table[] = static short vibrato_table[] =
...@@ -208,3 +214,5 @@ unsigned short snd_gf1_compute_freq(unsigned int freq, ...@@ -208,3 +214,5 @@ unsigned short snd_gf1_compute_freq(unsigned int freq,
} }
return (unsigned short) fc; return (unsigned short) fc;
} }
#endif /* 0 */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment