Commit 21039132 authored by Al Viro's avatar Al Viro

gfs2_atomic_open(): fix O_EXCL|O_CREAT handling on cold dcache

with the way fs/namei.c:do_last() had been done, ->atomic_open()
instances needed to recognize the case when existing file got
found with O_EXCL|O_CREAT, either by falling back to finish_no_open()
or failing themselves.  gfs2 one didn't.

Fixes: 6d4ade98 (GFS2: Add atomic_open support)
Cc: stable@kernel.org # v3.11
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent bf4498ad
...@@ -1248,7 +1248,7 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry, ...@@ -1248,7 +1248,7 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry,
if (!(file->f_mode & FMODE_OPENED)) if (!(file->f_mode & FMODE_OPENED))
return finish_no_open(file, d); return finish_no_open(file, d);
dput(d); dput(d);
return 0; return excl && (flags & O_CREAT) ? -EEXIST : 0;
} }
BUG_ON(d != NULL); BUG_ON(d != NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment