Commit 225af74d authored by Manish Narani's avatar Manish Narani Committed by Borislav Petkov

EDAC, synopsys: Correct comments

Spellcheck and improve/correct comments.
Signed-off-by: default avatarManish Narani <manish.narani@xilinx.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: Michal Simek <michal.simek@xilinx.com>
CC: amit.kucheria@linaro.org
CC: devicetree@vger.kernel.org
CC: leoyang.li@nxp.com
CC: linux-arm-kernel@lists.infradead.org
CC: linux-edac <linux-edac@vger.kernel.org>
CC: mark.rutland@arm.com
CC: michal.simek@xilinx.com
CC: robh+dt@kernel.org
CC: sudeep.holla@arm.com
Link: http://lkml.kernel.org/r/1538667328-9465-4-git-send-email-manish.narani@xilinx.com
parent bb894bc4
...@@ -96,12 +96,12 @@ ...@@ -96,12 +96,12 @@
#define SCRUB_MODE_SECDED 0x4 #define SCRUB_MODE_SECDED 0x4
/** /**
* struct ecc_error_info - ECC error log information * struct ecc_error_info - ECC error log information.
* @row: Row number * @row: Row number.
* @col: Column number * @col: Column number.
* @bank: Bank number * @bank: Bank number.
* @bitpos: Bit position * @bitpos: Bit position.
* @data: Data causing the error * @data: Data causing the error.
*/ */
struct ecc_error_info { struct ecc_error_info {
u32 row; u32 row;
...@@ -112,11 +112,11 @@ struct ecc_error_info { ...@@ -112,11 +112,11 @@ struct ecc_error_info {
}; };
/** /**
* struct synps_ecc_status - ECC status information to report * struct synps_ecc_status - ECC status information to report.
* @ce_cnt: Correctable error count * @ce_cnt: Correctable error count.
* @ue_cnt: Uncorrectable error count * @ue_cnt: Uncorrectable error count.
* @ceinfo: Correctable error log information * @ceinfo: Correctable error log information.
* @ueinfo: Uncorrectable error log information * @ueinfo: Uncorrectable error log information.
*/ */
struct synps_ecc_status { struct synps_ecc_status {
u32 ce_cnt; u32 ce_cnt;
...@@ -126,12 +126,12 @@ struct synps_ecc_status { ...@@ -126,12 +126,12 @@ struct synps_ecc_status {
}; };
/** /**
* struct synps_edac_priv - DDR memory controller private instance data * struct synps_edac_priv - DDR memory controller private instance data.
* @baseaddr: Base address of the DDR controller * @baseaddr: Base address of the DDR controller.
* @message: Buffer for framing the event specific info * @message: Buffer for framing the event specific info.
* @stat: ECC status information * @stat: ECC status information.
* @ce_cnt: Correctable Error count * @ce_cnt: Correctable Error count.
* @ue_cnt: Uncorrectable Error count * @ue_cnt: Uncorrectable Error count.
*/ */
struct synps_edac_priv { struct synps_edac_priv {
void __iomem *baseaddr; void __iomem *baseaddr;
...@@ -142,13 +142,11 @@ struct synps_edac_priv { ...@@ -142,13 +142,11 @@ struct synps_edac_priv {
}; };
/** /**
* get_error_info - Get the current ecc error info * get_error_info - Get the current ECC error info.
* @base: Pointer to the base address of the ddr memory controller * @base: Base address of the DDR memory controller.
* @p: Pointer to the synopsys ecc status structure * @p: Synopsys ECC status structure.
* *
* Determines there is any ecc error or not * Return: one if there is no error otherwise zero.
*
* Return: one if there is no error otherwise returns zero
*/ */
static int get_error_info(void __iomem *base, struct synps_ecc_status *p) static int get_error_info(void __iomem *base, struct synps_ecc_status *p)
{ {
...@@ -195,11 +193,11 @@ static int get_error_info(void __iomem *base, struct synps_ecc_status *p) ...@@ -195,11 +193,11 @@ static int get_error_info(void __iomem *base, struct synps_ecc_status *p)
} }
/** /**
* handle_error - Handle controller error types CE and UE * handle_error - Handle Correctable and Uncorrectable errors.
* @mci: Pointer to the edac memory controller instance * @mci: EDAC memory controller instance.
* @p: Pointer to the synopsys ecc status structure * @p: Synopsys ECC status structure.
* *
* Handles the controller ECC correctable and uncorrectable error. * Handles ECC correctable and uncorrectable errors.
*/ */
static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p)
{ {
...@@ -230,10 +228,10 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) ...@@ -230,10 +228,10 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p)
} }
/** /**
* check_errors - Check controller for ECC errors * check_errors - Check controller for ECC errors.
* @mci: Pointer to the edac memory controller instance * @mci: EDAC memory controller instance.
* *
* Used to check and post ECC errors. Called by the polling thread * Check and post ECC errors. Called by the polling thread.
*/ */
static void check_errors(struct mem_ctl_info *mci) static void check_errors(struct mem_ctl_info *mci)
{ {
...@@ -253,8 +251,8 @@ static void check_errors(struct mem_ctl_info *mci) ...@@ -253,8 +251,8 @@ static void check_errors(struct mem_ctl_info *mci)
} }
/** /**
* get_dtype - Return the controller memory width * get_dtype - Return the controller memory width.
* @base: Pointer to the ddr memory controller base address * @base: DDR memory controller base address.
* *
* Get the EDAC device type width appropriate for the current controller * Get the EDAC device type width appropriate for the current controller
* configuration. * configuration.
...@@ -284,12 +282,12 @@ static enum dev_type get_dtype(const void __iomem *base) ...@@ -284,12 +282,12 @@ static enum dev_type get_dtype(const void __iomem *base)
} }
/** /**
* get_ecc_state - Return the controller ECC enable/disable status * get_ecc_state - Return the controller ECC enable/disable status.
* @base: Pointer to the DDR memory controller base address * @base: DDR memory controller base address.
* *
* Get the ECC enable/disable status for the controller. * Get the ECC enable/disable status of the controller.
* *
* Return: a ECC status boolean i.e true/false - enabled/disabled. * Return: true if enabled, otherwise false.
*/ */
static bool get_ecc_state(void __iomem *base) static bool get_ecc_state(void __iomem *base)
{ {
...@@ -309,9 +307,9 @@ static bool get_ecc_state(void __iomem *base) ...@@ -309,9 +307,9 @@ static bool get_ecc_state(void __iomem *base)
} }
/** /**
* get_memsize - reads the size of the attached memory device * get_memsize - Read the size of the attached memory device.
* *
* Return: the memory size in bytes * Return: the memory size in bytes.
*/ */
static u32 get_memsize(void) static u32 get_memsize(void)
{ {
...@@ -323,8 +321,8 @@ static u32 get_memsize(void) ...@@ -323,8 +321,8 @@ static u32 get_memsize(void)
} }
/** /**
* get_mtype - Returns controller memory type * get_mtype - Return the controller memory type.
* @base: pointer to the synopsys ecc status structure * @base: Synopsys ECC status structure.
* *
* Get the EDAC memory type appropriate for the current controller * Get the EDAC memory type appropriate for the current controller
* configuration. * configuration.
...@@ -347,11 +345,11 @@ static enum mem_type get_mtype(const void __iomem *base) ...@@ -347,11 +345,11 @@ static enum mem_type get_mtype(const void __iomem *base)
} }
/** /**
* init_csrows - Initialize the cs row data * init_csrows - Initialize the csrow data.
* @mci: Pointer to the edac memory controller instance * @mci: EDAC memory controller instance.
* *
* Initializes the chip select rows associated with the EDAC memory * Initialize the chip select rows associated with the EDAC memory
* controller instance * controller instance.
* *
* Return: Unconditionally 0. * Return: Unconditionally 0.
*/ */
...@@ -381,11 +379,11 @@ static int init_csrows(struct mem_ctl_info *mci) ...@@ -381,11 +379,11 @@ static int init_csrows(struct mem_ctl_info *mci)
} }
/** /**
* mc_init - Initialize driver instance * mc_init - Initialize one driver instance.
* @mci: Pointer to the edac memory controller instance * @mci: EDAC memory controller instance.
* @pdev: Pointer to the platform_device struct * @pdev: platform device.
* *
* Performs initialization of the EDAC memory controller instance and * Perform initialization of the EDAC memory controller instance and
* related driver-private data associated with the memory controller the * related driver-private data associated with the memory controller the
* instance is bound to. * instance is bound to.
* *
...@@ -421,10 +419,10 @@ static int mc_init(struct mem_ctl_info *mci, struct platform_device *pdev) ...@@ -421,10 +419,10 @@ static int mc_init(struct mem_ctl_info *mci, struct platform_device *pdev)
} }
/** /**
* mc_probe - Check controller and bind driver * mc_probe - Check controller and bind driver.
* @pdev: Pointer to the platform_device struct * @pdev: platform device.
* *
* Probes a specific controller instance for binding with the driver. * Probe a specific controller instance for binding with the driver.
* *
* Return: 0 if the controller instance was successfully bound to the * Return: 0 if the controller instance was successfully bound to the
* driver; otherwise, < 0 on error. * driver; otherwise, < 0 on error.
...@@ -493,8 +491,8 @@ static int mc_probe(struct platform_device *pdev) ...@@ -493,8 +491,8 @@ static int mc_probe(struct platform_device *pdev)
} }
/** /**
* mc_remove - Unbind driver from controller * mc_remove - Unbind driver from controller.
* @pdev: Pointer to the platform_device struct * @pdev: Platform device.
* *
* Return: Unconditionally 0 * Return: Unconditionally 0
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment