Commit 228800db authored by Maximilian Attems's avatar Maximilian Attems Committed by Dave Jones

[PATCH] scsi/sd: replace schedule_timeout() with msleep()

Use msleep() instead of schedule_timeout() to
guarantee the task delays for the desired time.
Signed-off-by: default avatarNishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: default avatarMaximilian Attems <janitor@sternwelten.at>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent d1b92fac
...@@ -48,6 +48,7 @@ ...@@ -48,6 +48,7 @@
#include <linux/blkdev.h> #include <linux/blkdev.h>
#include <linux/blkpg.h> #include <linux/blkpg.h>
#include <linux/kref.h> #include <linux/kref.h>
#include <linux/delay.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
#include <scsi/scsi.h> #include <scsi/scsi.h>
...@@ -943,7 +944,6 @@ sd_spinup_disk(struct scsi_disk *sdkp, char *diskname, ...@@ -943,7 +944,6 @@ sd_spinup_disk(struct scsi_disk *sdkp, char *diskname,
* Issue command to spin up drive when not ready * Issue command to spin up drive when not ready
*/ */
} else if (SRpnt->sr_sense_buffer[2] == NOT_READY) { } else if (SRpnt->sr_sense_buffer[2] == NOT_READY) {
unsigned long time1;
if (!spintime) { if (!spintime) {
printk(KERN_NOTICE "%s: Spinning up disk...", printk(KERN_NOTICE "%s: Spinning up disk...",
diskname); diskname);
...@@ -962,12 +962,8 @@ sd_spinup_disk(struct scsi_disk *sdkp, char *diskname, ...@@ -962,12 +962,8 @@ sd_spinup_disk(struct scsi_disk *sdkp, char *diskname,
spintime_value = jiffies; spintime_value = jiffies;
} }
spintime = 1; spintime = 1;
time1 = HZ;
/* Wait 1 second for next try */ /* Wait 1 second for next try */
do { msleep(1000);
current->state = TASK_UNINTERRUPTIBLE;
time1 = schedule_timeout(time1);
} while(time1);
printk("."); printk(".");
} else { } else {
/* we don't understand the sense code, so it's /* we don't understand the sense code, so it's
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment