Commit 22f9d2f4 authored by Julia Lawall's avatar Julia Lawall Committed by Saeed Mahameed

net/mlx5: drop unnecessary list_empty

list_for_each_entry is able to handle an empty list.
The only effect of avoiding the loop is not initializing the
index variable.
Drop list_empty tests in cases where these variables are not
used.

Note that list_for_each_entry is defined in terms of list_first_entry,
which indicates that it should not be used on an empty list.  But in
list_for_each_entry, the element obtained by list_first_entry is not
really accessed, only the address of its list_head field is compared
to the address of the list head, so the list_first_entry is safe.

The semantic patch that makes this change is as follows (with another
variant for the no brace case): (http://coccinelle.lip6.fr/)

<smpl>
@@
expression x,e;
iterator name list_for_each_entry;
statement S;
identifier i;
@@

-if (!(list_empty(x))) {
   list_for_each_entry(i,x,...) S
- }
 ... when != i
? i = e
</smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent c8b838d1
...@@ -474,14 +474,13 @@ static int dr_matcher_add_to_tbl(struct mlx5dr_matcher *matcher) ...@@ -474,14 +474,13 @@ static int dr_matcher_add_to_tbl(struct mlx5dr_matcher *matcher)
int ret; int ret;
next_matcher = NULL; next_matcher = NULL;
if (!list_empty(&tbl->matcher_list)) list_for_each_entry(tmp_matcher, &tbl->matcher_list, matcher_list) {
list_for_each_entry(tmp_matcher, &tbl->matcher_list, matcher_list) { if (tmp_matcher->prio >= matcher->prio) {
if (tmp_matcher->prio >= matcher->prio) { next_matcher = tmp_matcher;
next_matcher = tmp_matcher; break;
break;
}
first = false;
} }
first = false;
}
prev_matcher = NULL; prev_matcher = NULL;
if (next_matcher && !first) if (next_matcher && !first)
......
...@@ -574,9 +574,8 @@ void mlx5dr_rule_update_rule_member(struct mlx5dr_ste *ste, ...@@ -574,9 +574,8 @@ void mlx5dr_rule_update_rule_member(struct mlx5dr_ste *ste,
{ {
struct mlx5dr_rule_member *rule_mem; struct mlx5dr_rule_member *rule_mem;
if (!list_empty(&ste->rule_list)) list_for_each_entry(rule_mem, &ste->rule_list, use_ste_list)
list_for_each_entry(rule_mem, &ste->rule_list, use_ste_list) rule_mem->ste = new_ste;
rule_mem->ste = new_ste;
} }
static void dr_rule_clean_rule_members(struct mlx5dr_rule *rule, static void dr_rule_clean_rule_members(struct mlx5dr_rule *rule,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment